Repository navigation
chore(spec): mark PolicySchema properties experimental — kill false compliance (ADR-0049 #1882) - #1923
Merged
Conversation
…ompliance (ADR-0049 #1882) ADR-0049's "mark experimental now" disposition for the dangling PolicySchema was only half-applied: the top-of-file JSDoc and `name` were marked, but the actual sub-properties (password complexity, session idle/absolute timeout, `forceMfa`, IP allow-list, audit retention/redaction) still had plain `.describe()` text. So the generated reference docs showed e.g. `forceMfa` as "Require 2FA for all users" with no caveat — a false-compliance signal for a property that enforces nothing (better-auth runs hardcoded defaults). This propagates `[EXPERIMENTAL — not enforced]` to every PolicySchema property so the no-op is explicit in the published docs and to the spec-liveness gate. Description-only — no behaviour change. Liveness gate (security): 26 live / 35 experimental / 32 dead, 0 unclassified. The PolicySchema tree moves dead→experimental (marker-driven); the remaining 32 dead (isProfile, contextVariables, SharingRule's runtime divergence, and the no-roadmap Territory/RLSConfig/RLSAuditConfig removal candidates) stay as the enforce-or-remove worklist. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
size/m
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 89 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operationalizes ADR-0049's "mark
experimentalnow" disposition forPolicySchema(#1882), which was only half-applied.The gap
policy.zod.tshad a top-of-file JSDoc warning and a markedname, but the actual sub-properties — password complexity, session idle/absolute timeout,forceMfa, the IP allow-list, audit retention/redaction — still carried plain.describe()text. JSDoc doesn't reach generated artifacts, so the published reference docs showedforceMfaas "Require 2FA for all users" with no caveat — a false-compliance signal for a property that enforces nothing (better-authruns hardcoded defaults; PolicySchema isn't even registered as a metadata type).Change
Propagate
[EXPERIMENTAL — not enforced]to every PolicySchema property. Description-only — no behaviour change. The marker now reaches:content/docs/references/security/policy.mdx— regenerated;forceMfaetc. now flagged), andexperimentalinstead ofdead.Liveness gate (security) after this PR
26 live / 35 experimental / 32 dead, 0 unclassified (was26 / 1 / 66). The PolicySchema tree + the already-markedallow{Transfer,Restore,Purge}move dead→experimental, driven by the spec markers (ledger reconciled so markers are the source of truth). The remaining 32 dead stay as the enforce-or-remove worklist:isProfile,contextVariables, the specSharingRuleruntime divergence, and the no-roadmap removal candidates (Territory/TerritoryModel/RLSConfig/RLSAuditConfig).Part of the long-term spec↔runtime alignment track. Builds on #1919 (the gate) and ADR-0049 (the umbrella decision).
🤖 Generated with Claude Code