Skip to content

check:keyed-text-bounds: skip tmp/, move scaffold test's temp root under node_modules #17421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baozhoutao merged 1 commit into from
Sep 10, 2026
Merged

check:keyed-text-bounds: skip tmp/, move scaffold test's temp root under node_modules #17421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/cli/test/init-scaffold-authoring-rules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,16 @@
* (`writeTemplateSrcFiles`) and checked through the command's own self-test
* (`validateScaffold`), so neither half can drift from what `init` really does.
*
* Temp projects are created under this package's git-ignored `tmp/` (not
* `os.tmpdir()`) because the rendered config imports `@objectstack/spec`,
* which only resolves where Node can walk up into this package's
* `node_modules`. Keeping them out of `test/` also keeps generated `.ts` away
* from any glob that collects sources.
* Temp projects are created under this package's own `node_modules` (not
* `os.tmpdir()`, and not this package's `tmp/`) because the rendered config
* imports `@objectstack/spec`, which only resolves where Node can walk up
* into this package's `node_modules` -- the same reasoning
* `generate-scaffold-validates.test.ts` documents for its own materialized
* scaffolds. `node_modules` is git-ignored and already excluded from every
* source-walking gate, so a run killed before `afterAll` runs (a timeout, the
* container's foreground cap, `ctrl-c`) leaves inert litter behind instead of
* files a repo-wide scan can trip over. Keeping them out of `test/` also
* keeps generated `.ts` away from any glob that collects sources.
*/

import { describe, it, expect, afterAll } from 'vitest';
Expand All @@ -46,7 +51,7 @@ import { TEMPLATES, sanitizeNamespace, writeTemplateSrcFiles } from '../src/comm
import { validateScaffold, SCAFFOLD_RULE_COMMAND } from '../src/utils/scaffold-validate.js';

const HERE = path.dirname(fileURLToPath(import.meta.url));
const TMP_ROOT = path.resolve(HERE, '../tmp');
const TMP_ROOT = path.resolve(HERE, '../node_modules/.init-scaffold-authoring-rules');
const PROJECT_NAME = 'my-app';

const roots: string[] = [];
Expand Down
1 change: 1 addition & 0 deletions scripts/check-keyed-text-bounds.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ const MIN_KEYED_TEXT_COLUMNS = 140;

const SKIP_DIRS = new Set([
'.git', 'node_modules', 'dist', 'build', 'coverage', '.turbo', '.next', '.cache', '.changeset',
'tmp',
]);

/** Where shipped object declarations are discovered. */
Expand Down
Loading