Skip to content

docs(app-crm): point two stale approval comments at the real consumers #14840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sales merged 1 commit into from
Sep 3, 2026
Merged

docs(app-crm): point two stale approval comments at the real consumers #14840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions examples/app-crm/src/objects/opportunity.object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,12 @@ export const Opportunity = ObjectSchema.create({
min: 0,
max: 100,
}),
// Mirror target for the Discount Approval flow's approval nodes
// (ADR-0019). The approval runtime writes the request status here; it is
// readonly to users so only the flow drives it.
// Mirror target for an approval node's `approvalStatusField` (ADR-0019):
// the approval runtime writes the request status here, so it stays
// readonly to users. This app declares no approval flow of its own — the
// CRM keeps one flow on purpose (src/flows/index.ts); the worked approval
// flows are examples/app-showcase/src/automation/flows/, and the
// `approvalStatusField` wiring is shown in skills/objectstack-automation/SKILL.md.
approval_status: Field.select({
label: 'Approval Status',
readonly: true,
Expand Down
7 changes: 6 additions & 1 deletion examples/app-crm/src/security/sales-positions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ export const SalesManagerPosition = definePosition({
description: 'Manages a team of sales reps.',
});

/** Referenced by the Discount Approval second step. */
/**
* Registered in `objectstack.config.ts` (`positions`) and bound to the
* `crm_sales_user` permission set by `bind-position-sets.ts`, alongside
* `sales_rep` and `sales_manager`. This app models no approval flow; the
* worked approval flows live in `examples/app-showcase/src/automation/flows/`.
*/
export const FinanceApproverPosition = definePosition({
name: 'finance_approver',
label: 'Finance Approver',
Expand Down
Loading