Skip to content

spec(api): make ApiEndpoint.target optional; publish gate holds the flow requirement - #11290

Merged
os-sam merged 2 commits into
mainfrom
claude/issue-10338-endpoint-target-optional
Aug 23, 2026
Merged

os-sam merged 2 commits into
mainfrom
claude/issue-10338-endpoint-target-optional

Conversation

@claude

@claude claude Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Fixes #10338

Implements the maintainer ruling of 2026-08-23 (issue comment, verbatim 「其他同意你的意见」 adopting recommendation A): ApiEndpoint.target becomes optional in the vocabulary; the publish gate requires it for type: 'flow' — an object_operation author stops writing a dead string. The ruling is the authorization to edit the #5040 §0-frozen vocabulary for this key.

Premise readings (re-verified on origin/main at 064d484)

  • packages/spec/src/api/endpoint.zod.ts:171 — target: z.string(), required, no .optional()/.default(). Confirmed.
  • packages/spec/src/api/endpoint-publish-gate.ts targetGate — requires target for flow only (if (!endpoint.target)), never reads it for object_operation. Confirmed.
  • Executor/OpenAPI split — packages/runtime/src/endpoint-executor.ts planEndpointTarget reads endpoint.target only in the flow branch; packages/rest/src/openapi-endpoints.ts likewise (if (!endpoint.target) on the flow branch only). Confirmed. Every consumer is a truthiness check, so undefined behaves exactly as '' did.

Zero-migration measurement (ruling premise clause)

Optional-izing z.string() → z.string().optional() is a pure widening: the accepted-value set strictly grows, so no previously valid value can be rejected. Measured, not just argued:

  • Scripted parse of every in-tree module-exported ApiEndpoint declaration through the rebuilt schema: 4 parsed, 0 rejected (examples/app-showcase allApis ×2, qa/dogfood endpoint-policy-fixture ×2 — all carrying string targets except the swept task-feed example).
  • Full @objectstack/spec suite (all inline endpoint fixtures included): 11112/11113 passed on first run; the single failure was a pin of the OLD required-ness (metadata-type-api-registration.test.ts "refuses a body missing target"), replaced per fixture triage below. 108/108 green on the three touched files after.

No stored-row corpus exists in-tree; stored rows carry string targets written under the required-era schema, which the widened schema accepts by construction. Premise holds — no migration, no ADR-0087 entry (nothing an author could write is removed; the change is acceptance-widening plus a gate that already existed).

What changed

  • Vocabulary (endpoint.zod.ts): target is .optional(); the .describe() now states the per-type truth — REQUIRED at publish for type: 'flow', UNREAD for object_operation (do not write it there).
  • Publish gate (endpoint-publish-gate.ts): unchanged by design — targetGate already refuses !endpoint.target for flow, which now also covers the newly-expressible omitted key. New pins:
    • gate refuses a flow endpoint that OMITS target, at issue path apis.0.target, message "names no target flow" (apis-publish-gates.test.ts);
    • gate ACCEPTS an object_operation endpoint with no target (apis-publish-gates.test.ts — the pin that goes red if required-ness is restored);
    • vocabulary parses an object_operation without the key (endpoint.test.ts).
  • code+status pinned case (ruling clause ②): the publish gate's EndpointGateIssue is issue-shaped (path + message) by contract — no ADR-0112 envelope exists at the spec layer. The envelope for this refusal lives at the gate's declared runtime counterpart (planEndpointTarget → unsupportedAnswer), so the pin asserting both code and status is there: a flow endpoint with target omitted answers 501 with error.code === 'NOT_IMPLEMENTED', message "names no target flow", conformant envelope, nothing delegated (endpoint-executor.test.ts).
  • Old-contract fixture replaced (metadata-type-api-registration.test.ts): the "refuses a body missing target" pin asserted the vocabulary-level refusal this ruling removes. Replaced with the new-contract pin: a headless body parses at the shape door and is refused by the GATE — at objectParams for object_operation, at target for flow.
  • Corpus sweep — every in-tree object_operation declaration teaching the dead key:
    • examples/app-showcase/src/system/apis/index.ts — dropped target: 'showcase_task' (comment explains).
    • examples/app-showcase/test/gap-fill.test.ts — the object-existence check now reads objectParams.object (what the executor delegates on) instead of the unread target.
    • content/docs/api/declarative-endpoints.mdx — example drops the key; the "target is required on every entry" paragraph rewritten to the per-type contract.
    • content/docs/protocol/kernel/http-protocol.mdx, content/docs/getting-started/quick-reference.mdx — examples drop the key with a one-line comment.
    • content/docs/references/api/endpoint.mdx — regenerated (gen:schema && gen:docs), now lists target as optional with the new description.
    • Left in place, deliberately: packages/qa/dogfood/test/fixtures/endpoint-policy-fixture.ts still writes target on two object_operation fixtures — they parse fine and are outside this card's declared file surface (packages/qa); they are fixtures, not shipped teaching. skills/objectstack-api/SKILL.md also still teaches the key — skills are a governed surface outside this card's file surface; filed separately (see report).
  • Changeset: .changeset/lazy-pugs-shake.md, @objectstack/spec minor. Non-breaking (widening), so no ADR-0087 disposition marker is required; check-adr-0087-registration green.

Reverse verification (predicted directions stated first)

  1. Prediction: restoring required-ness turns the new acceptance pins red. Mutation: re-add required target in endpoint.zod.ts (z.string()), rebuild spec, run the three spec test files. Observed: 4 pins red, exactly the predicted set — parses an object_operation endpoint that omits target (endpoint.test.ts), the gate acceptance pin, the gate omit-refusal pin (red because the refusal became a Zod invalid_type at apis.0.target instead of the gate's message), and the headless-body pin — 104/108 others green. Disk proof: 0 occurrences of the .optional() spelling after mutation, 1 after restore. Honesty note: the dist --absent preflight was inconclusive — the marker target: z.string().optional().describe is NOT unique in spec (ui/action.zod, automation/state-machine.zod, api/odata.zod also spell it) — but the measured surface (spec's own tests) imports the schema by relative src path, so the mutation provably reached it; both legs were rebuilt regardless.
  2. Prediction: ablating the flow-target gate check turns the flow-refusal pins red (gate test), while the runtime 501 pin stays green (it pins the runtime counterpart, not the gate). Mutation: short-circuit if (!endpoint.target) in targetGate, rebuild, run. Observed: 4 gate pins red as predicted — the empty-target pin, the omit-target pin, the three-rejections aggregate (one FEWER rejection: the diagnostics-shrink direction), and the flow half of the headless pin — while the runtime endpoint-executor suite stayed GREEN 50/50, demonstrating the 501 code+status pin exercises the runtime counterpart, not the gate. Unique marker false && !endpoint.target: 1 src occurrence during mutation, 0 after restore. Dist note: the mutation-leg preflight found the marker only in sourcemaps — esbuild constant-folds false && … out of executable output — so the dist proof for that leg rests on the sourcemaps + rebuild plus the src resolution of the measured tests; the restore-leg --absent preflight passed over all 209 built files.

Both legs: mutation proven on disk (anchored grep of the mutated text), rebuilt via pnpm --filter @objectstack/spec build with scripts/ablation-dist-preflight.mjs marker checks on mutation AND restore legs, restore via git checkout from the committed state.

Verification

All local verification below ran on the final tree; final commit 9ff4da688 (the last two runs' logs and the gate re-derivation cite it; earlier suite runs executed on a byte-identical tree whose only uncommitted files were the ones commit 9ff4da688 then committed verbatim).

  • @objectstack/spec full suite: first run 11112/11113 (the 1 red was the old required-target pin, replaced); after replacement the three touched files: 108/108 (Test Files 3 passed).
  • @objectstack/runtime full suite: 184 files / 2711 tests passed (Tests 2711 passed (2711)).
  • @objectstack/rest full suite: 138 files / 2201 tests passed.
  • @objectstack/metadata targeted (publish-endpoint-gate, endpoint-matcher, match-endpoint, stored-envelope): 4 files / 103 tests passed; @objectstack/metadata-protocol targeted: 2 files / 73 tests passed.
  • @objectstack/example-showcase full suite (edited gap-fill included): 25 files / 367 tests passed.
  • turbo run typecheck over spec/runtime/rest/metadata/metadata-protocol/example-showcase: 64 tasks successful (each named package's tsc --noEmit echoed).
  • pnpm --filter @objectstack/spec check:generated: 1 stale artifact (check:docs), regenerated via --fix; all others up to date (its own report line: "1 of 14 artifact(s) stale").
  • Derived gate families (dispatch-gates at 9ff4da688, --repo asserted, set unchanged from first derivation): doc gates (anchors/authoring/audit-scope/redirects/frontmatter/security-posture via lint filter runs at CI), check:quick-reference-counts, check:role-word, check:published-readme-links, check:merge-driver, check:objectui-changeset, check:examples-live-imports, check:changeset-gate-self-tests, check-adr-0087-registration, check-changeset-no-major, check-empty-changeset, check-ci-filter-parity, check-plugin-teardown-shape, check-doc-frontmatter, check-nul-bytes, docs-audit/check-affected-docs, check-cross-package-test-inputs, check:spec-parsed-alias, check:slot-lookup, check:test-source-alias, check:type-source-resolution, check:published-files, check:query-options-erasure, check:engine-double-contract, check:where-matcher, check:empty-state, check:variant-docs, check:liveness + check:strictness-ledger (inside check:generated) — all exit 0. Convention-triggered: check:type-check-coverage OK, check:type-check-debt --re-measure OK (none above recorded), check:skill-examples ✅ 227 prose examples, check-dev-prereqs ✓ after full ./packages/* build.
  • Zero-migration script: MEASUREMENT: 4 parsed, 0 rejected of 4 in-tree declarations.

Not run locally (CI-owned): repo-wide pnpm lint (eslint sweep) and the full farm — deliberate narrowing per the seat's standing verification-scope rule; CI runs the farm on the PR.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 2 documentable anchor(s).

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/declarative-endpoints.mdx (via ApiEndpointSchema (symbol), object_operation (literal))
  • content/docs/getting-started/quick-reference.mdx (via object_operation (literal))
  • content/docs/protocol/kernel/http-protocol.mdx (via ApiEndpointSchema (symbol), object_operation (literal))
What this run could not see

Coarse fallback — 126 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 764dbbccbd00bbf61936bf128be524e8d8ad1bed → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 7c63d692d1850bacbc19d4c48e7b15ca7f239f7e — the merge of head 9ff4da688eeae4f27aa672a7e600da86b56f758b into base 764dbbccbd00bbf61936bf128be524e8d8ad1bed, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 7c63d692d1850bacbc19d4c48e7b15ca7f239f7e && git checkout 7c63d692d1850bacbc19d4c48e7b15ca7f239f7e
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 764dbbccbd00bbf61936bf128be524e8d8ad1bed 9ff4da688eeae4f27aa672a7e600da86b56f758b && git checkout -B drift-repro 764dbbccbd00bbf61936bf128be524e8d8ad1bed && git merge --no-ff 9ff4da688eeae4f27aa672a7e600da86b56f758b

node scripts/docs-audit/affected-docs.mjs --json 764dbbccbd00bbf61936bf128be524e8d8ad1bed

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 764dbbccbd00bbf61936bf128be524e8d8ad1bed → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests tooling labels Aug 23, 2026
Merged via the queue into main with commit d2619fd Aug 23, 2026
55 of 59 checks passed
os-zhuang pushed a commit that referenced this pull request Aug 24, 2026
…ect_operation example (#11291)

`ApiEndpoint.target` became optional in #10338 (landed as #11290): it is
required at publish only for `type: 'flow'` and is UNREAD for
`type: 'object_operation'`, which is addressed by `objectParams.object` /
`.operation`. Nothing checks a `target` written beside them against
`objectParams.object`, so the `leadFeed` example was teaching a dead string —
the exact AI-authoring trap #10338 removed. The in-tree examples and the
protocol/getting-started docs were swept in #11290; the published skill was
out of that card's file surface.

The example now omits the key. No explanatory note was added: the published
skills token ratchet had zero headroom on this file (ceiling 6348, file 6348),
and the card made that note conditional on budget. The gate-description lines
(~212-214) already state the per-type rule ("an `object_operation` needs both
`objectParams` halves; a `flow` needs a `target`") and stay unchanged.

Lower the file's ratchet ceiling 6348 -> 6342 to lock in the saving, per the
ratchet's own documented discipline ("a ceiling may be LOWERED by any PR that
shrinks its file ... always legitimate and encouraged").

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_5213b871-5164-5bc3-8874-28b336bbcd40
akarma-synetal pushed a commit to akarma-synetal/framework that referenced this pull request Oct 7, 2026
…decision in words instead of a tracker number (stage 24) (objectstack-ai#21961)

Part of objectstack-ai#20749
Clause-②: no

Stage 24 of this card: the next area of class (e), the test strings
shipped under `packages/spec/src`, as ruled in `5902360492` on objectstack-ai#20513.
This stage takes the first name-ordered `api/` group: the 27 id-bearing
test files directly under `packages/spec/src/api/` from
`ai-agents-envelope.test.ts` to `package-lifecycle.test.ts`. Those files
carried 100 messages and 106 tracker ids, citing 65 records. All 106 now
either state what their record decided, in words (form D), or are
dropped where the title already says it. No needle sits in this group.
Text only: no assertion, identifier, test count or code comment changes,
and no file is renamed.

## Census at the base (`a3bd157730`)

Instruments: `census10.cjs` (md5 `9d08602ab972b4b8643c90d64d40fa41`),
`census.cjs` (md5 `6e42a45a926d375013c32d62f16a296e`), `census-wide.cjs`
(md5 `c98410a19529c439adb0afbfb00026a2`) and `dirtable.cjs` (md5
`dda605c54745b4a60cc14c9a686e4eff`), byte-identical to the copies stages
10 to 23 used. A literal counts as a test title when its folded message
is argument 0 of a `describe` / `it` / `test` call, `.each` / `.skip` /
`.only` chains included. Everything else is an "other" string.

The worktree was cut from `origin/main` at `a3bd157730`, the claim's
base and stage 23's landing. Both instruments read **471 messages / 498
ids in 111 files**, the seat's reading and stage 23's head reading.

| directory | files | messages / ids | titles | other |
|:--|--:|--:|--:|--:|
| `api/` (this PR: 27 of the 40 files) | 40 | 189 / 201 | 181 / 193 | 8
/ 8 |
| `system/` | 34 | 154 / 167 | 128 / 138 | 26 / 29 |
| (files directly in `src/`) | 30 | 118 / 120 | 117 / 119 | 1 / 1 |
| `ui/` | 5 | 7 / 7 | 0 | 7 / 7 |
| `ai/` | 1 | 2 / 2 | 0 | 2 / 2 |
| `contracts/` | 1 | 1 / 1 | 0 | 1 / 1 |
| **total** | **111** | **471 / 498** | **426 / 450** | **45 / 48** |

The group reads **100 messages / 106 ids in 27 files**, the seat's
figures file for file:

| file (under `api/`) | messages / ids | titles | other |
|:--|--:|--:|--:|
| `ai-agents-envelope.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `analytics.test.ts` | 3 / 3 | 3 / 3 | 0 |
| `api-entry-graph.pin.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `api-error-code-type.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `apis-publish-gates.test.ts` | 12 / 12 | 12 / 12 | 0 |
| `auth-endpoints.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `auth.test.ts` | 2 / 2 | 1 / 1 | 1 / 1 |
| `automation-api.zod.test.ts` | 4 / 5 | 4 / 5 | 0 |
| `batch.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `contract.test.ts` | 3 / 3 | 3 / 3 | 0 |
| `dataset-selection.test.ts` | 5 / 5 | 5 / 5 | 0 |
| `discovery-auth-families.pin.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `discovery-environment-subset.pin.test.ts` | 2 / 2 | 1 / 1 | 1 / 1 |
| `discovery.test.ts` | 10 / 11 | 10 / 11 | 0 |
| `dispatcher.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `endpoint.test.ts` | 4 / 4 | 4 / 4 | 0 |
| `envelope-violations.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `error-code-ledger.test.ts` | 7 / 11 | 7 / 11 | 0 |
| `errors.test.ts` | 3 / 3 | 3 / 3 | 0 |
| `export-job-family-retirement.test.ts` | 6 / 6 | 3 / 3 | 3 / 3 |
| `export.test.ts` | 3 / 3 | 3 / 3 | 0 |
| `meta-item-response-shapes.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `metadata.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `odata-orderby-dual-declaration.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `package-api.test.ts` | 10 / 10 | 10 / 10 | 0 |
| `package-install-one-authority.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `package-lifecycle.test.ts` | 9 / 9 | 9 / 9 | 0 |
| **27 files** | **100 / 106** | **95 / 101** | **5 / 5** |

Five more test files sit in the same name range and carry no id
(`documentation.test.ts`, `error-catalog-docs.test.ts`,
`events.test.ts`, `http-cache.test.ts`, `odata.test.ts`). The five
"other" strings are expect messages, rewritten and declared to the
text-only tool: `auth.test.ts:155`,
`discovery-environment-subset.pin.test.ts:65` (one leaf of a `+` chain)
and `export-job-family-retirement.test.ts:112` (a template literal),
`:158` and `:349`.

- **Controls.** Lit: `ui/notification.test.ts` (1 id) and
`api/protocol.test.ts` (50 ids), outside the group, read the same at the
base and at the head. Dark: `package-api.test.ts` reads 0 at the head
while 30 of its comment lines still carry a number. Planted in a scratch
tree: an id put into a `package-lifecycle.test.ts` title reads 1 / 1
(`title:describe`), and an id put into a `batch.test.ts` comment reads
0.
- **A wider pattern** (any `#` plus digits) reads the same as the gate
pattern in all 27 files at the base, and 0 in all 27 at the head.
- **At the head:** 371 messages / 392 ids in 84 files. The 27 files read
0 / 0, `api/` reads 89 / 95 in 13 files, and no other file moved.

## How the area was chosen

`api/` has no subdirectory, so it is taken in name-ordered file groups
near the ~100-id bound, the rule stages 20 to 23 used. Stage 23's cut
named this group at 106 ids, and this census reads 106, so no re-cut was
needed.

**Named for the next stages** (cut from the head census, 371 / 392):
- **The second `api/` group:**
`plugin-rest-api.handler-status-retirement.test.ts` through
`zod-issues-to-fields.test.ts`, 13 files, 89 messages / 95 ids (86 / 92
titles, 3 / 3 other), `protocol.test.ts` alone 46 / 50 and
`rest-server.test.ts` 19 / 19. That finishes `api/`.
- `system/` 167, two stages. The files directly in `src/`, 120, one.
- The needles: the three docblock needles, the kept
`ui/component-props-unknown-members.pin.test.ts:322` and stage 22's two.
One stage, with an at-tier review. The four colour literals stay, as
stage 21 decided.

## What each id became

- **18 literals (22 ids)** now state a decision in words.
- **10 literals (10 ids)** get their subject back in words, where the
number stood for a thing.
- **72 literals (74 ids)** drop a number the title already explains.

Every cited record was fetched with all its comments through REST (357
comments, objectstack-ai#4052's included), and its decision was read from its ruling,
ACCEPT and landing comments. 65 records are cited: 59 answer 200 and 6
answer 404. Two of the 200s are PRs (objectstack-ai#4049 and objectstack-ai#20218), read from their
bodies. One citation is objectui's and was read from objectui:
`objectui#6593`. The six that answer 404 were read from what landed,
through the commits endpoint (this checkout is shallow), each named by
the commit the stage-2 re-anchoring of `api/` comments gave it:
- **objectstack-ai#6287**, from `84c86fb454` (objectstack-ai#6610): `preview` and `trial` fold to
`sandbox` by declaration, and the fold table is typed total over
`EnvironmentType`;
- **objectstack-ai#6704**, from `c3f4916266` (objectstack-ai#7015): `ImportRequest.runAutomations`
declares the default the import route applies;
- **objectstack-ai#10330**, from `b9e9227e36` (objectstack-ai#11316): `mappingName` declared on
`ImportRequestSchema`, with the mutual-exclusion refine;
- **objectstack-ai#10338**, from `d2619fd0cd` (objectstack-ai#11290): `ApiEndpoint.target` is
optional, and the publish gate holds the flow requirement;
- **objectstack-ai#11504**, from `f90e820249` (objectstack-ai#12611): `FLOW_INPUT_SCHEMA_INVALID`
registered, the never-dispatched code;
- **objectstack-ai#16649**, from `613bfbd3db` (objectstack-ai#16879): the fourteen remaining `door:
'none'` codes registered.

One citation names a different record. `batch.test.ts:78` read "(objectstack-ai#3963
follow-up)"; objectstack-ai#3963 is the `api.requireAuth` retirement. The
`validateOnly` tombstone is objectstack-ai#4052's decision, read too: never
implemented, so tombstoned rather than half-built. The title already
says that ("rejects the retired `validateOnly` key with its
prescription"), so the number is dropped.

Where a record's decision was refined later, the title follows the
refined one:
- **objectstack-ai#4936 and objectstack-ai#5111:** objectstack-ai#4936's ruling refused every non-empty `apis:`;
objectstack-ai#5111 narrowed that to per-endpoint gates. The `:152` title says what
held through both: an empty or absent `apis:` was never refused.
- **objectstack-ai#4910 Q2:** that ruling left endpoint-level `rateLimit` unwired and
tracked under objectstack-ai#4936; objectstack-ai#4936's ruling then kept it in the vocabulary for
the endpoint executor to wire. The title names that destination.
- **objectstack-ai#17518:** its 2026-09-13 ruling was re-presented and briefly
replaced (batch objectstack-ai#149, withdrawn as unexecutable), then confirmed (batch
objectstack-ai#159, letter A) and given its mechanism (batch objectstack-ai#192, letter A′), which
adds the record-stage body. The title "the row's manifest is the RECORD
stage" is that body, so only the number goes.
- **objectstack-ai#18605:** ruling letter 1 made the request contract the one
authority, and objectstack-ai#18877's later ruling made that key optional so the door
sees an absence; the title says only "has ONE authority", which both
keep, so only the number goes.

**Stated in words:**

| record | literal (under `api/`) | now reads | the decision |
|:--|:--|:--|:--|
| objectstack-ai#18576 | `api-entry-graph.pin.test.ts:77` | "… stays off the assembled
package body (ruled: split the entry rather than watch its weight)" |
Ruling B (batch objectstack-ai#145 item 1, maintainer 2026-09-17): the cost is
removed, not watched; `./api` is split and the assembled-package
declarations move to `@objectstack/spec/api-assembled`. |
| objectstack-ai#4936 | `apis-publish-gates.test.ts:152` | "still accepts an EMPTY and
an ABSENT `apis:` — never refused, even while a non-empty one was" |
Maintainer ruling 2026-08-04: v17 loudly refuses a non-empty `apis:` and
keeps the vocabulary; an empty or absent one stays publishable, then and
after objectstack-ai#5111's narrowing. |
| objectstack-ai#4910 | `apis-publish-gates.test.ts:568` | "keeps endpoint-level
`rateLimit` in the vocabulary (ruled: left to the endpoint executor, not
the server-level seam)" | Q2 = B (2026-08-03): that card wires the
server level only; the endpoint-level keys stay, and objectstack-ai#4936's ruling has
the endpoint executor wire them. |
| objectstack-ai#5189 | `apis-publish-gates.test.ts:597` | "still refuses D6 — the
gate with no runtime counterpart, so the per-item publish path runs it
too" | Triage disposition (E7b, 2026-08-04): `publishPackage` reuses the
same gate function, because D6 alone has no runtime counterpart. |
| objectstack-ai#7481 | `auth-endpoints.test.ts:112` | "AuthFeaturesConfig retired
flags (ruled: stop advertising them)" | Maintainer ruling 2026-08-11:
`passkeys` / `magicLink` leave the `/api/v1/auth/config` payload. |
| objectstack-ai#14788 | `auth.test.ts:88` | "SessionUser.language retirement
(ADR-0049 — ruled: gone, with no replacement field)" | Maintainer ruling
D (2026-09-03): retired under ADR-0049, no producer and no consumer; no
replacement field until a real producer exists. |
| objectstack-ai#9378, objectstack-ai#9510 | `automation-api.zod.test.ts:327` | "… status, runId and
the screen (a pause is the third state, not a failure)" | objectstack-ai#9510's ruling
(2026-08-18): a pause is not a failure, and callers learn the third
state deliberately; `status: 'paused'` + `runId` + `screen` is the
trigger contract's third state. |
| objectstack-ai#4828 | `discovery.test.ts:1167` | "scoping (ruled: declare what REST
actually emits)" | Maintainer ruling 2026-08-05, item 3: `scoping` is
declared on `DiscoverySchema` as an optional key. |
| objectstack-ai#4828 | `discovery.test.ts:1207` | "resolveDiscoveryEnvironment
(ruled: an enum, not a passthrough)" | Item 4: the schema is
authoritative, so every producer's `environment` is mapped into the
declared enum. |
| objectstack-ai#8211 | `error-code-ledger.test.ts:68` | "standard-synonym detection
(ruled: refused unless waived)" | Option C (triage adjudication,
2026-08-12): the admission gate refuses a semantic synonym of a standard
member unless a recorded waiver admits it; the four existing ones are
waived. |
| objectstack-ai#10025, objectstack-ai#11504 | `error-code-ledger.test.ts:220` | "accepts the
definition-level input-schema refusal code (ruled non-retryable: a
never-dispatched exit)" | Maintainer ruling B (2026-08-20): the refusal
is non-retryable and becomes a never-dispatched exit with its own
ADR-0112 code. |
| objectstack-ai#16449, objectstack-ai#16404 | `error-code-ledger.test.ts:234` | "accepts the
nine-code batch — every code that ships in dist, door or no door (ruled:
the ledger is the published face)" | objectstack-ai#16404 option D (batch objectstack-ai#62,
2026-09-07): the ledger is the published face, so every code in `dist`
is registered; objectstack-ai#16449 registered the nine. |
| objectstack-ai#16649, objectstack-ai#16404 | `error-code-ledger.test.ts:308` | "accepts the
fourteen remaining door:none codes, each under its stamping package
(ruled: the ledger is the published face)" | The same ruling;
`613bfbd3db` registered the fourteen. |
| objectstack-ai#17158 | `export-job-family-retirement.test.ts:158`, `:349` (expect
messages) | "… the retirement is being undone — nothing served, bound or
consumed the family" | Ruling A (batch objectstack-ai#122 item 3, 2026-09-12; landing
route A, batch objectstack-ai#221 item 2): ADR-0049 retires a declared API that
nothing serves, binds or consumes. |
| objectstack-ai#12038 | `package-api.test.ts:603` | "package-rollback-response
retirement (ruled: it described the wrong operation on the live path)" |
Ruling 3A (2026-08-27): the published version-rollback schema, bound to
the live commit-rollback path, is retired first. |
| objectstack-ai#12038 | `package-lifecycle.test.ts:25` | "the ruled re-export of
PackagePublishResultSchema into the `/api` namespace" | Ruling 5A:
re-export the existing schema into the namespace the ledger resolver
searches, never a second copy. |
| objectstack-ai#12038 | `package-lifecycle.test.ts:140` |
"RollbackToPackageCommitResponseSchema declares the COMMIT-rollback body
(ruled: authored once the wrong-operation schema was retired)" | Ruling
3A's binding sequence: retire the false declaration, then author the
true commit-rollback schema. |

**Subject back in words** (10 literals): "the pre-objectstack-ai#4053 bare body"
becomes "the bare body from before the envelope relocation" (objectstack-ai#4053's end
state: both producers relocated the payload under `data`); "(objectstack-ai#3891 shim
dialect)" becomes "(the degraded shim dialect)"; "the duplicate-payload
drift objectstack-ai#4049 removed" becomes "the duplicate-payload drift the
/share-links domain stopped emitting", the PR's own title; "zero holders
after objectstack-ai#17158" becomes "after the export-job family retirement"; "the
objectstack-ai#10330 TS2353 repro" becomes "the original TS2353 repro"; the three
"since PR objectstack-ai#20218" titles become "since the door parses its whole body"
(twice) and "so does the door, which parses the whole body", the PR's
own title; the `objectstack-ai#17534` title now names "the reverse-domain id rule",
that card's ruling A; "the objectui#6593 confusion" becomes "the
envelope-vs-payload `success` confusion", the defect objectui#6593
measured.

**Dropped where already stated** (72 literals, 74 ids). A number goes
only where the title already says its decision. Examples: the eight
`[objectstack-ai#5111]` describes ("the flip — a well-formed `apis:` publishes", "gate
(a)" to "gate (e)", …), `[objectstack-ai#5310]`, `[objectstack-ai#19920]`, the two `[objectstack-ai#21046]`,
`[objectstack-ai#5676]`, `[objectstack-ai#5672]`, `[objectstack-ai#5679]` and `[objectstack-ai#6287]` prefixes; the four
`objectstack-ai#17551` / `objectstack-ai#17550` section prefixes in `dataset-selection.test.ts`,
which keep the file's own `§1` to `§5`; `objectstack-ai#5384 —`, `objectstack-ai#5227 —`, `objectstack-ai#5950`,
`objectstack-ai#5882`, `objectstack-ai#17518`, `objectstack-ai#18058 —` and `objectstack-ai#18605 —`; the four `objectstack-ai#15677`
citations on the "→ …Seconds" renames; and the tails `(objectstack-ai#3878)`,
`(objectstack-ai#6442)`, `(objectstack-ai#19543)` x2, `(objectstack-ai#7359)`, `(objectstack-ai#3939)`, `(objectstack-ai#18124)`, `(objectstack-ai#3842)`
x3, `(objectstack-ai#10338)`, `(objectstack-ai#6704)`, `(objectstack-ai#10330)`, `(objectstack-ai#4587)`, `(objectstack-ai#17667)`,
`(objectstack-ai#19116)`, `(objectstack-ai#17431)`, `(objectstack-ai#19441)`, `(objectstack-ai#8211)`, the five `(objectstack-ai#12038)` and
the one `(objectstack-ai#12038 4A)` after "declares the four fixed keys and stays
open". `(federated ledger, objectstack-ai#4805)`, `(ADR-0076 D12, objectstack-ai#2462)` and
`(ADR-0112 amendment 2026-08-18, objectstack-ai#9266)` keep their words and lose the
number. The ADR-0087 conversion id
`api-endpoint-cache-ttl-to-cache-ttl-seconds` stays: it is not a tracker
id.

**No file is renamed.**

## Readers

- **`error-code-ledger.test.ts`** (11 ids in 7 titles): no ledger, gate
or self-test reads its strings. `scripts/check-error-code-casing.mjs`
names the file only to exempt it whole ("the ledger admission test");
the ledger's docblock and its generated reference page name the file,
never a title; the provenance and dispatcher-vocabulary gates read
`error-code-ledger.zod.ts`, not the test.
- **Needles:** none. The five declared strings are all assertion failure
messages (the second argument of `expect`), none is an expected value,
and no title or message in the group is matched against a source
docblock or another file's text.
- **Test-name filters:** none. No tracked script, workflow or package
config passes `-t` / `--testNamePattern` to vitest; the one vitest `-t`
hit is a README example under `packages/qa/dogfood` filtering its own
fixture.
- **Snapshots:** none. No `__snapshots__` directory is tracked under
`packages/spec`, and none of the 27 files calls a snapshot matcher.
- **Projects:** `export-job-family-retirement.test.ts` is in the `repo`
project (`packages/spec/vitest.repo-tests.json:30`); the other 26 run in
`local`. The base-versus-head run below takes both projects.
- **By substring:** every old literal, its id-bearing fragment and a
window around each id (294 needles) was searched with `git grep` at the
base, across the tracked tree outside its own file. No gate, doc,
filter, snapshot, QA checklist entry or `scripts/check-*.mjs` self-test
reads one. The 17 hits are windows that share wording with code comments
and one CHANGELOG line: "(ADR-0076 D12, objectstack-ai#2462)" in comments in
`runtime/http-dispatcher.ts`, `spec/api/discovery.zod.ts` and
`objectql/protocol-discovery.test.ts` and at
`packages/runtime/CHANGELOG.md:14161`; "(objectstack-ai#18576 ruling, letter B)" in
three comments; "(objectstack-ai#3891 shim dialect)" in
`runtime/domains/analytics.ts:41`; "is retired (objectstack-ai#19543)" in
`spec/api/automation-api.zod.ts:645`.

## Text-only proof

Stage 10's scratch tool (`textonly10.cjs`, md5
`d5e4801dbb4329ab1984da91e92fc47c`) compares base and head file by file
on three legs:
1. **Skeleton:** the full AST, with string pieces masked. It must be
identical.
2. **Comments:** every comment, byte-equal.
3. **Strings:** each changed string leaf must sit in a test-call title
position or on a declared line, must carry a tracker id before, and must
carry no `#` plus digits after. This stage declares the five
expect-message lines named above.

- **Result:** 27 of 27 files SAME on all three legs, with the per-file
counts predicted in writing before the run.
- **Totals:** 100 changed string leaves in 100 literals: 95 titles and 5
declared. The diff's `+` and `-` lines are exactly the 100 planned lines
as multisets, and every file keeps its line count.
- **Controls (14 of 14 as predicted on the first run, on scratch copies,
each anchor hit once):** identifier rename DIFF; numeric literal DIFF;
comment edit COMMENT DIFF; a non-title string given an id VIOLATION; a
rewritten title given a new id VIOLATION; a title that was id-free at
base edited VIOLATION; one title reverted to base SAME; an `it.each` row
given an id VIOLATION; an undeclared expect message changed VIOLATION; a
title re-split into a `+` chain DIFF; a declared expect message reverted
to base SAME; a declared expect message given a new id VIOLATION; a
declared `+`-chain leaf given a new id VIOLATION; a template-literal
message given a new id VIOLATION.
- **Templates and tables:** no `.each` title and no `$name` placeholder
changes. The one template literal,
`export-job-family-retirement.test.ts:112`, changes only its text after
`${name}`.

**Test counts:** the 27 files were run at the base, in a separate base
worktree, and at the head, with `--project local --project repo`. Both
sides read 831 tests in 27 files, all passed, with the same count and
status sequence per file in 27 of 27. 325 full test names change, and
each changed name equals the base name with the planned replacements
applied: 0 mismatches once the plan's text is read the way the source
writes it (the comparison tool reads the plan's `—` escape at
`errors.test.ts:439` literally, so its first pass reports that title's
three names as mismatches; decoding the escape, as vitest does, reads
0). No full name repeats on either side.

## Changeset: `skip-changeset`

Measured, not assumed:
- `npm pack --dry-run` of `@objectstack/spec` lists 2068 files. 0 of the
27 touched files are in it, and no `*.test.ts` at all. The controls
`src/api/package-lifecycle.zod.ts`, `src/api/error-code-ledger.zod.ts`
and `dist/index.mjs` are in it.
- In the built `dist/`, a new phrase and an old one each read in 0
files. The control `Unrecognized key` reads in 42.

So this PR publishes nothing, and no changeset is added.

## Verification (at `dffd240655`)

- `pnpm turbo run build` over all packages: 71 / 71, through the shared
verify lock (`VERDICT command-exit 0`).
- `@objectstack/spec`:
  - `vitest run --project local`: 619 files, 18471 passed, 1 todo.
- `typecheck`: exit 0, including `check:test-typecheck` (52 files / 246
errors / 135 pinned signatures held). Its program holds all 27 group
files, counted by path with `tsc --listFilesOnly -p tsconfig.test.json`.
- `check:generated`: all 15 generated artifacts up to date, against the
`dist/` the build above wrote.
- **Gates:** `dispatch-gates --commands` derived 80 families: stage 23's
79 plus `check:error-code-casing`, which the two touched files it names
bring in. All 80 exit 0. `--ran` reconciles: 80 derived, 80 run, 0
NOT-MEASURED, 0 UNRUN, every family with its exit code recorded. The
same 80 derive from `origin/main` `01e0f71ad8` with this diff applied.
The roster families stage 23 also ran (`check:meta-url-spelling`,
`check:spec-changes`, `check:authz-resolver`,
`check:filter-alias-parity`) each exit 0.
- **ESLint, a proven narrowing:** `--no-inline-config` over the 27 files
reads 0 errors and 0 warnings. The population comes from ESLint's own
config: 27 configured, 0 ignored. No file sets `parserOptions.project`
or `projectService`, so no untouched file's verdict can move.
- `check-governed-merges --test`: NOT governed, 200 changed lines (+100
/ -100).
- A control-byte scan over the 27 changed files finds none.

## `main` since the base

Re-fetched just before this PR opened, `origin/main` was two commits
past the base (`01e0f71ad8`: objectstack-ai#21940, objectstack-ai#21953). They touch 31 files, none
of the 27 and none under `packages/spec`, so `main` was not merged and
the census on that tree is the base's. `git merge-tree` onto
`01e0f71ad8` is clean, and none of the 5 open PRs touches any of the 27
files.

## Acceptance notes

- **Same-id test titles in this card's later stages** go with those
stages: 23 lines in `packages/spec/src`, among them
`api/protocol.test.ts` (`[objectstack-ai#5672]` x2, `(objectstack-ai#12038)` x5, `(objectstack-ai#12038 1C)`,
`(objectstack-ai#19543, door ③)`), `api/plugin-rest-api.test.ts`, `api/router.test.ts`
and `api/websocket.test.ts` (`(objectstack-ai#15677)`),
`stack-json-stage-package-body.test.ts` (`objectstack-ai#17518` x4),
`system/book.test.ts` (`(objectstack-ai#12038)`) and three `system/` titles citing
`(objectstack-ai#18124)`.
- **Same-id test titles in other packages** stay: 96 lines in 12
packages (`runtime` 37, `rest` 24, `client` 9, `metadata-protocol` 6,
`service-automation` 6, `metadata` 5, `cli` 3, `objectql` 2, and one
each in `examples/app-showcase`, `core`, `plugin-hono-server` and
`verify`), each package's share under the objectstack-ai#20513 lane children.
- **Code comments with live ids** remain in these files and their
sources, among them the `// package-rollback-response retirement (objectstack-ai#12038
3A)` banner above its describe, the `[objectstack-ai#5111 / objectstack-ai#5040 E7]` and `[objectstack-ai#5189 /
objectstack-ai#5040 E7b]` headers in `apis-publish-gates.test.ts`, and the `[objectstack-ai#17158]`
header in `export-job-family-retirement.test.ts`. Code comments are not
this card's share.

---

_Generated by [Claude
Code](https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tests tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant