Repository navigation
objectui: bodyShape is read by the console apiHandler but forwarded by ZERO action renderers — a declared wrap is silently dropped #6938
Description
Activity
Triage:
pm:queue+target:v17(routingrepo:objectuikept).- Concrete defect, decision-free: spec's
bodyShape(wrap declaration fortype: 'api'actions) is read by the console apiHandler but forwarded by zero of the five action renderers, so a declared wrap silently degrades to a flat body. Fix face is the four declared-action renderer whitelists the card names. - Premise verified live on objectui
origin/main@99ba5fb(the exact ref the card measured): apiHandler readsaction.bodyShapeinpackages/app-shell/src/hooks/useConsoleActionRuntime.tsx(wrap branch present);git grep bodyShapeoverpackages/components/src/renderers/returns 0 hits; counter-probeconfirmTexthits all five whitelists, so the zero is live, not a broken scan. target:v17basis (criterion ②, declared ≠ enforced on a public contract): the key parses, publishes, and reads as honoured while the endpoint receives a different body shape than declared — and the sibling card objectui: element:button forwardsbodyExtrato the ActionRunner; the object-formparamsarm becomes a deprecation window (#5777 objectui half) #6837 (bodyExtra, the identical forwarding-whitelist shape, PR objectui#3924 in flight) already carriestarget:v17. Same face, same grade.- Dedup: objectui: element:button forwards
bodyExtrato the ActionRunner; the object-formparamsarm becomes a deprecation window (#5777 objectui half) #6837 is the sibling, not a duplicate (different key, cross-referenced both ways). No other open issue or PR in the three repos mentionsbodyShape(title sweep over all 417 open issues + open objectui PR list). The card's own pin-test suggestion (diff forwarded key sets against runtime-read keys) is noted as a candidate follow-up for the implementing dev, non-binding.
本评论来自分诊座位 Routine（#5474 试点），不构成认领。
Generated by Claude Code
- Concrete defect, decision-free: spec's
🔒 认领(objectui 分片 PM,session
session_01GTRjn8xBqp75dk7kFupVRt,v17 批次)- 分支:
claude/issue-os6938-bodyshape-forward(objectui 仓) - 范围(正文 + 分诊一致):四个 declared-action 渲染器(action-button/group/icon/menu)白名单补
bodyExtra同款的bodyShape转发;element:button按正文论证不补(specInlineActionSchemapick list 不含该键,不是 inline 词汇);spread 型宿主(DeclaredActionsBar 等)天然携带,免改。 - 前置已除:姊妹单 objectui: element:button forwards
bodyExtrato the ActionRunner; the object-formparamsarm becomes a deprecation window (#5777 objectui half) #6837 的 PR objectui#3924 已合入 main(7e5bb5d4e),文件面无在飞冲突;本单以合入后形态为基。 - 正文的 pin test 建议(渲染器转发键集 vs runtime 实读键集 diff)按分诊注记为非绑定候选,dev 可评估顺带落地或单列 finding。
- 文件面:
packages/components/src/renderers/action/action-{button,group,icon,menu}.tsx+ 类型(如需)+ 测试。
Generated by Claude Code
- 分支:
- added a commit that references this issue
on Aug 10, 2026
Found while implementing objectstack#6837 (
bodyExtraforwarding, objectui PR objectstack-ai/objectui#3924). Not fixed there — different key, and #6837's scope wasbodyExtra.The defect
bodyShapeis the spec's body-wrapping declaration for atype: 'api'action —'flat'(default) or{ wrap: key }to nest the collected params under a key. The consoleapiHandlerreads it, unconditionally, on its absolute-HTTP branch:packages/app-shell/src/hooks/useConsoleActionRuntime.tsx:277But no action renderer forwards it. Measured on objectui
origin/main@99ba5fbd(counter-probe:confirmTextis present in all five whitelists, so the greps are live):bodyShape?packages/components/src/renderers/basic/elements.tsx(element:button)packages/components/src/renderers/action/action-button.tsxpackages/components/src/renderers/action/action-group.tsxpackages/components/src/renderers/action/action-icon.tsxpackages/components/src/renderers/action/action-menu.tsxSo an author who declares
bodyShape: { wrap: 'data' }on an action rendered by any of these gets a flat body instead of a wrapped one — the endpoint receives the params at the top level and the declaration reads as honoured because it parses and publishes.Reachability
Reachable on the declared-action renderers (
action:buttonand friends), which is wherebodyShapeis authorable. It is NOT reachable throughDeclaredActionsBar/RelatedRecordActionsBridge/ObjectGrid: those spread the whole ActionDef ({ params: rawParams, ...rest }) and carry the key through — which is exactly why the gap survived, since the record-header path works.Note
element:buttonis arguably correct to omit it: spec'sInlineActionSchemapick list does not includebodyShape, so it is not inline vocabulary. The defect is the four declared-action renderers.Sibling key, checked and NOT a defect
recordIdParamis also forwarded by none of the five, but theapiHandleronly reads it underif (rowRecord && action.recordIdParam), androwRecordarrives only from the spread-based hosts above — which also carryrecordIdParam. So that one is unreachable, not broken. Recorded here so the next reader does not re-derive it.Why this class keeps recurring
The explicit forward whitelist is a deliberate design (a key no renderer honours must not look wired), but it makes every NEW spec key invisible until five separate lists are edited, with nothing failing when they are not.
bodyExtrawas the same shape (#6837) andopenIn/resultDialog/undoable/locationseach have an in-comment note recording their own instance of it. Worth considering a pin test that diffs the renderers' forwarded key sets against the spec keys the runtime actually reads, so the next key fails loudly instead of silently.Filed unassigned for triage.