Skip to content

finding: packages/client/README.md documents client.notifications.list({ unreadOnly: true }) — a parameter that has never existed (the real one is read) #6927

Description

@os-zhuang

Filed by the domain:spec seat PM on behalf of the #6361 dev (session ran out of runway post-quota-kill; reported in the #6361 final report, reproducible). Observation-class; finding disposition for triage — no pm:queue, unassigned.

packages/client/README.md:259 (anchor as of origin/main at the #6361 base) shows the one usage example for client.notifications.list as list({ unreadOnly: true }). The method's options have always been { read?, type?, limit? } (post-PR #6866: cursor tombstoned) — unreadOnly was never a parameter. An author (or AI author) copying the README's only example for this method gets a silently ignored key and an unfiltered list; the correct spelling is read: false.

Independent of the #6361/#6866 cursor change; same doc-teaches-a-key-nothing-reads family as #5435. Dedup: searched open issues for unreadOnly — no hits.

Activity

  1. claude commented on Aug 9, 2026

    @claude
    Contributor

    Triage: pm:queue + domain:cli — graded straight to the queue rather than held.

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

  2. self-assigned this
    on Aug 10, 2026
  3. os-help commented on Aug 10, 2026

    @os-help
    Collaborator

    Claim: PM loop round 1 (cli lane, new shift)
    Session: session_0158ZQo7LiHSxGWpYKuPq1wu
    Branch: claude/issue-6927-readme-unreadonly
    Worktree: objectstack-issue-6927
    Domain: domain:cli
    File surface: packages/client/README.md only (stop on breach; explain in the report)
    Container & model: S mechanical card (XS, decision-free per triage), mode:subagent, model: sonnet
    Serial constraints cleared: none — no in-flight claim touches packages/client.

    Premise re-verified at dispatch time on origin/main @ 5d24f4b: README.md:259 still shows list({ unreadOnly: true }).


    Generated by Claude Code

  4. os-help commented on Aug 10, 2026

    @os-help
    Collaborator

    ACCEPT — PR #7194 (review of record, cli-lane PM, round 1).

    • Shipped: the only usage example for client.notifications.list in packages/client/README.md now uses the real option — { read: false } // unread only — instead of the never-existed unreadOnly: true. Single hunk, 1+/1−, verified independently via git diff origin/main...8eaf523 (not from the dev report).
    • Dev grepped all of packages/client: this line was the only unreadOnly occurrence, matching triage's dedup.
    • CI: all 31 check runs completed; ESLint and TypeScript Type Check both success. Docs-only ⇒ skip-changeset (already on the PR).
    • Landing: flipping ready and arming auto-merge into the merge queue now; will confirm MERGED against origin/main.

    Generated by Claude Code

  5. added a commit that references this issue on Aug 17, 2026
    e5ecc5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions