You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ARCHITECTURE.md links to docs/adr/0001-metadata-service-architecture.md, deleted 2026-02-11 — the link 404s #6733
Found while implementing #6634 (the ADR-0079 dangling-pointer fix); out of that PR's scope, filed unassigned.
The fact
ARCHITECTURE.md:653 carries a markdown link, not a bare mention:
- [ADR-0001: Metadata Service Architecture](docs/adr/0001-metadata-service-architecture.md) - Explains why both ObjectQL and MetadataPlugin can provide metadata service and how they work together
That file was deleted on 2026-02-11 in 9da8e3e72 ("feat(docs): add comprehensive analysis of Permission Protocol...") together with docs/adr/0002-database-driven-metadata-storage.md and docs/adr/README.md. Verified against the full history (the working clone is shallow by default — this needs git fetch --deepen before git log --diff-filter=D -- 'docs/adr/*' says anything true).
So a reader of ARCHITECTURE.md who follows the repo's most prominent pointer to "why both ObjectQL and MetadataPlugin can provide metadata service" reaches a 404.
Different defect, different fix. #6634 is about a number cited with no record; this is a link to a path that was removed, and fixing it means deciding what the correct target is (the explanation may have moved into another ADR, or may need re-homing) — a docs judgement, not a mechanical repoint.
The other two ADR-0001 sites in the tree are fine and should not be touched:
docs/adr/0002-environment-database-isolation.md:122 — "already discarded in v3.4's ADR-0001", legitimate history.
examples/app-showcase/src/ui/pages/{project-detail,project-workspace}.page.ts — these cite ObjectUI ADR-0001, a different repo's registry.
The PR for #6634 extends check:adr-anchors to assert every cited ADR number resolves, and puts 0001 on a shrink-only UNRESOLVED_ADR_CITATIONS allowlist (deleted record, cited as history). The entry's comment names this broken link explicitly and says the allowlist does not bless it — the allowlist is per-number and cannot distinguish "history" from "broken link" at that granularity. Fixing this issue does not require removing the allowlist entry (ADR-0002's historical mention keeps it earning its place).
Note .github/workflows/check-links.yml (advisory lane, repo-internal links, restored 2026-08-07) would plausibly have caught this — worth checking why it does not, but that file is under active work elsewhere and is not part of this report.
Classification: concrete defect, named location, scoped fix — a 404ing link plus one docs judgement (what the correct target is). Queueable; the target-choice judgement is editorial, not a product-contract decision, so it does not go to the maintainer's inbox.
Note for the implementer: fixing this must not edit docs/adr/** content (ADRs are maintainer-merged only per the 2026-08-08 standing discipline; this card is an ARCHITECTURE.md link repair, which stays outside that guardrail).
Release board: no target:* — internal contributor docs.
Activity
os-zhuang commentedon Aug 8, 2026
Triage:
pm:queue+domain:devx.origin/main@3172831—ARCHITECTURE.md:653still carries the markdown link todocs/adr/0001-metadata-service-architecture.md, and that path is absent from the tree (git show origin/main:docs/adr/0001-…fails). Root-level repo docs sit closest to thedomain:devxdocs/gates row; the directly adjacent ADR-registry-integrity cards [finding] ADR-0079 is cited ~30 times repo-wide (14× in packages/spec) but no docs/adr/ file exists — dangling pointer, neighbours 0076–0078 and 0080–0082 all present #6634,docs/adr/is outside theCheck Linksscan surface — ADR cross-links are unverified, and the obvious widening goes red on ADR-0046's illustrative links #6592, docs/adr has a number hole at 0107 — either a withdrawn record with no tombstone, or a lost file #6676 all carrydomain:devx.pm:dispatched) is the sibling class but a different record and explicitly declines to fix this one. Itscheck:adr-anchorswidening puts0001on a shrink-only allowlist that does NOT bless this link — no conflict, noBlocked-by:.docs/adr/**content (ADRs are maintainer-merged only per the 2026-08-08 standing discipline; this card is anARCHITECTURE.mdlink repair, which stays outside that guardrail).target:*— internal contributor docs.本评论来自分诊座位 Routine(#5474 试点),不构成认领。
Generated by Claude Code
os-project-manager commentedon Aug 9, 2026
认领 / Claim
session_01F8q5J1MQyocgtNspb15fSnclaude/issue-6733-architecture-dead-adr-link作用域:仅修
ARCHITECTURE.md中指向已删除docs/adr/0001-metadata-service-architecture.md的死链,并顺带核查同文件内其它 ADR/源码指针。⛔ 不会新建/恢复/修改docs/adr/**(AGENTS.md Prime Directive #14,ADR 变更仅由 maintainer 落地);若结论是「需要重写一份 ADR」,将改为上报而非动手。Generated by Claude Code