Repository navigation
[finding] guard-governed-enqueue's 「no checkout available」 fail-open is pinned by no self-test case in any environment — the case that claimed it never reaches it; one hermetic case with the injected empty root #18367
Description
Activity
Claim: PM loop round 1 (skills seat, successor shift)
Session:session_01HPfcjvF23QBoBj7P47DDxs
Branch:claude/issue-18367-enqueue-guard-fail-open-selftest
Worktree:objectstack-issue-18367
Domain:domain:skills
File surface:.claude/hooks/guard-governed-enqueue.selftest.sh(one new hermetic case reaching the 「no checkout … is available」 fail-open, with a firing control);.claude/hooks/guard-governed-enqueue.sh⛔ unchanged unless the case reveals a defect — then report, do not widen (stop on breach; explain in the report)
Container & model:S (test-only pin, but the fixture and the control assertion are a design judgment),mode:subagent,model: claude-opus-5— default judgment tier;node scripts/pm/dispatch-gates.mjs --tier .claude/hooks/guard-governed-enqueue.selftest.shat 2026-09-16T10:01Z on588475c3: 「Model tier — no path-derived mandate: the surface hits none of the 3 declared glob(s) … floor sonnet · default opus · ceiling fable」; not taken to the floor because the card's own phantom-check lesson (the text assertion must go red under a control) is a judgment, not a mechanical edit; in-seat review atCONTRACT_REVIEW_TIER.
Clause-②: no
Thread-read: none
Ruling-ref: none — no maintainer ruling on this card; lane self-triage grading in the body (p3 · Task), class (a) unpinned branch.
Serial constraints cleared:.claude/hooks/guard-governed-enqueue.sh+.selftest.sh— chain per the seat post's hot-file line: PR #18390 LANDED40eaf755(09:14Z) → this card → #18384 (pm:queue, unclaimed, SERIAL behind this card on the same two files; fold-or-serial answered SERIAL — gate ① fails, an unpinned branch vs a missing match arm). PR #183658b81ab60(theOS_GOVERNED_ENQUEUE_SIBLING_ROOTinjection this case uses) LANDED 06:41Z. No open PR and no in-flight claim touches these files. No sibling card's pin asserts the behaviour this card pins. Premise re-read on588475c3at 2026-09-16T10:01Z: the selftest's cross-repo case (its own comment: 「AND IT DOES NOT REACH THE "no checkout … is available" FAIL-OPEN — measured」) still assertsallowwithout the warning;check-governed-merges.mjs --test skills/zz-no-such-skill/references/_index.mdstill exits 3 with one exception row; the hook's fail-open text 「no checkout of OWNER/REPO is available to recompute its provenance on」 is still at itswarncall; the selftest passes 62 / 62 on this tree.
Generated by Claude Code
os-dev-report
{
"issue": 18367,
"status": "done",
"branch": "claude/issue-18367-enqueue-guard-fail-open-selftest",
"pr": "#18423",
"pr_number": 18423,
"pr_head_sha": "e3a22ebf5aae78114331077dcba15be2a9f520fc",
"pr_draft": true,
"session": "session_01HPfcjvF23QBoBj7P47DDxs",
"premise_still_valid": true,
"base": "90b23ab1d4e93a78c4f59855ab0bbb2fa7f7b693 (origin/main at worktree creation; the dispatch named 588475c — the rule-1 fetch advanced origin/main by one commit, 90b23ab, which touches neither hook file:git diff --stat 588475c..90b23ab -- .claude/hooks/ scripts/pm/check-governed-merges.mjsis empty)",
"summary": "Added one hermetic self-test case (4 assertions) to .claude/hooks/guard-governed-enqueue.selftest.sh pinning the hook's 'no checkout of OWNER/REPO is available to recompute its provenance on' fail-open. It reuses the empty sibling root the existing cross-repo case already injects and changes only the path shape, to skills/zz-no-such-skill/references/_index.md — a skills path no generator declares, so the register answers governed (exit 3) with one exception row wherever it is asked, which is the branch's whole precondition. Asserts allow plus the two load-bearing halves of the warning, and a firing control (the same payload with the sibling resolved) asserts the sentence is absent there. The hook itself is unchanged; nothing in writing the case revealed a defect in it. assignee was empty on arrival and stays empty.",
"tests": "BASELINE 62/62 on the worktree base (90b23ab) and 66/66 with the new case, both viaOS_VERIFY_LOCK_SLOT=dev-18367 bash scripts/pm/os-verify-lock.sh -c 'bash .claude/hooks/guard-governed-enqueue.selftest.sh'(VERDICT command-exit 0, 20s and 27s under the lock, 0s waited). RED-UNDER-CONTROL (one-time, from the COMMITTED implementation): the says row naming the repo was pointed at the RESOLVED sibling root instead of the empty one; on-disk proof before any verdict was read — grep counts NO_SIBLING_ROOT 4 -> 3 and resolved SIBLING_ROOT 2 -> 3, HEAD blob 2d9f332ea518826251a8f760d8d3e9bed72a2dde vs working blob 9b6f2bc7c26375f36d18aac97ba0a0d61ad9c515; the run then printed 'FAIL missing "no checkout of objectstack-ai/cloud" the fail-open names the repo it could not resolve / 65 passed, 1 failed'. Restored withgit checkout HEAD -- PATHunder a trap using absolute paths, proven by bytes:git diff HEAD --statempty andgit hash-objectback to 2d9f332e. HERMETICITY measured in both directions: the register answers exit 3 with one exception row in this installed worktree (reason: the generator 'does not write' the path, not among the 9 declared outputs) AND in the un-installed shared checkout (reason: 'the generator declared no output set (the generator's own --check exited 254)'); the hook takes the fail-open and prints the warning in both (HOOK_EXIT=0).",
"gates": "dispatch-gates --commands derived 14 families for this path; 14 run in the foreground with exit codes captured before any pipe, all exit 0, pluspnpm check:pm-settings-deny-roster(exit 0) which the derivation flags as a roster living under .claude.dispatch-gates --ranreconciliation: '14 derived, 14 run, 0 NOT-MEASURED, 0 UNRUN' — a DERIVED zero (every line records an exit code). One family needed a prerequisite first:pnpm --filter @objectstack/lint run check:doc-formula-expressionsexited 3 (PREREQUISITE NOT MET — unbuilt @objectstack/lint and @objectstack/formula, measures nothing), re-run to exit 0 afterpnpm exec turbo run build --concurrency=2 --filter=@objectstack/formula --filter=@objectstack/lintunder the same lock slot. No package's test/typecheck is owed: the diff is one bash file under .claude, touching no workspace package. CI convergence not awaited (per the dev contract).",
"line_budget": "not a skills/** ratchet surface — .claude/hooks/** publishes nothing and carries no line ceiling. File 572 -> 633 lines (+61: 4 assertion rows, one printed register-verdict diagnostic, the rest the case's own comment register). Package total not applicable.",
"files_changed": [
".claude/hooks/guard-governed-enqueue.selftest.sh"
],
"changeset": "none — AGENTS.md Post-Task Checklist step 3, acted on verbatim: 'neverskip-changeset: that label is for a diff that publishes nothing from any released package.' This diff is one file under .claude/, shipped by no package's files[], so nothing publishes; theskip-changesetlabel was applied additively and read back (labels on the PR read back exactly ['skip-changeset']).",
"deviations": [
"Base is 90b23ab, not the dispatched 588475c: rule 1's recipe isgit fetch origin main && git worktree add ... origin/main, and the fetch advanced origin/main by one commit. That commit touches neither hook file nor the register, so every dispatched reading still holds; all measurements in this report are on 90b23ab.",
"A1 reason text: in the INSTALLED worktree the exception row reads 'does not write that path — not among the 9 file(s) that generator declared', i.e. the card's wording, not the PM's un-installed variant. The PM's variant was reproduced read-only in the shared checkout (no node_modules). Both are exit 3 with one exception row, so the fail-open precondition holds either way and the case does not depend on which.",
"Commit trailer pair is the model-free one AGENTS.md mandates (Claude-Session plus a bare Co-authored-by) rather than the harness attribution lines, which name a model; AGENTS.md wins on conflict and the pre-push hook enforces it —check:commit-card-trailerspassed on the push with 'no card relation and no model identifier in the trailer pair'."
],
"mcp_calls": "0 — no MCP GitHub tool was called, read or write.",
"api_writes": "3 REST proxy writes: POST /repos/objectstack-ai/objectstack/pulls (draft), POST /repos//issues/18423/labels, POST /repos//issues/18367/comments (this report). Plus 2git push(the empty-branch write-route probe, exit 0, and the commit). No PATCH of the card, no second Claim, no assignee write.",
"open_questions": [],
"out_of_scope_findings": [
"noted, not filed: the case's premise is that skills/zz-no-such-skill/references/_index.md stays undeclared by every generator; if a real skill ever takes that name the two text rows go red rather than silently passing, and the printed register-verdict line names why in one line. Carrier: the next PR to touch this matrix.",
"noted, not filed: the register's exception reason differs between an installed and an un-installed tree (declared-output list vs '--check exited 254'), same exit code and same row count. Not a defect — both are the fail-closed arm — but it is why this case asserts the hook's sentence and never the register's reason. Carrier: none."
]
}
Generated by Claude Code
ACCEPT — skills seat,
session_01HPfcjvF23QBoBj7P47DDxs, 2026-09-16T10:22Z. Report 5695878694 · PR #18423 (draft, heade3a22ebf, basemain, first lineFixes #18367).Checklist, verified against GitHub and the tree — not against the report's narrative:
- Shape / scope: draft ✓ · base
main✓ · closing keyword on the first line and nowhere else ✓ · changed files =.claude/hooks/guard-governed-enqueue.selftest.shonly (+61 / −0), the hook untouched ✓ · nocontent/docs/releases/✓ ·skip-changesetmatches AGENTS.md's own arm (the label 「is for a diff that publishes nothing from any released package」;.claude/**ships in no package'sfiles[]) ✓. - The case, read in the diff: one new block after the cross-repo case — payload path
skills/zz-no-such-skill/references/_index.md(undeclared by every generator ⇒ the register answers exit 3 + one exception row wherever asked), injected root = the emptyNO_SIBLING_ROOTthe previous case already builds; assertsallow+says 'no checkout of objectstack-ai/cloud'+says 'recompute its provenance'; the firing controlexpect_lacks 'no checkout of'runs the same payload against the RESOLVED sibling root. The register verdict line is printed, not asserted. This is what the card asked for (the branch + a control that makes the text rows falsifiable). - Test evidence, re-run by the seat:
bash .claude/hooks/guard-governed-enqueue.selftest.shon a detached worktree ate3a22ebf→66 passed, 0 failed(base reads 62). The red-under-control demonstration in the PR body (mutating thesaysrow's root to the resolved one →65 passed, 1 failed, restored by blob hash) is the dev's; the seat did not repeat the mutation, and records that as the one reading taken from the report rather than re-measured. - Gates: the body lists 14 derived families +
check:pm-settings-deny-roster, all exit 0,--ranreconciled 14 / 14;check-clause2-carriers.mjs --pair 18423exit 0 on the seat's side. CI one3a22ebfat review time: 27 of 29 check-runssuccess/skipped,Lint & Repo GatesandType Check · consumer gatesstillin_progress— a convergence reading that belongs to the landing window, not to this verdict. - Writes:
mcp_calls0 ·api_writes3 REST (draft PR, one label, this report) + 2 pushes — within the dispatched budget; no assignee write, no second claim. - Deviations accepted: base
90b23ab1(rule-1 fetch advancedorigin/mainby one commit touching neither hook file); commit trailers per AGENTS.md's model-free pair. - Out-of-scope findings: two
noted, not filedentries, both boundaries of the case's own premise; neither is in the three filing classes — agreed, nothing to file.
Path face (
check-governed-merges.mjs --teston the changed path):.claude/**⇒ GOVERNED, rules layer ⇒ terminal four-piece, ⛔ not landed by any seat: ① this comment is the review of record · ②needs-user-decisionon PR #18423 + the seat's 速读终稿 as a PR comment · ③ review requested fromos-zhuangandhotlong· ④ listed under awaiting a human merge in the round report. After an authorized APPROVED (GOVERNED_APPROVERS, not dismissed): ruling C — this seat lands it (record on the current head,--pair0, all checks green or rostered skips, clear the label, ready via the CCR route, auto-merge SQUASH). Card stayspm:dispatched+ assignee until MERGED closes it byFixes. Hot-file chain: #18384 is now SERIAL behind this PR on the same two files.
Generated by Claude Code
- Shape / scope: draft ✓ · base
Landed — skills seat,
session_01HPfcjvF23QBoBj7P47DDxs, 2026-09-16T11:03Z. PR #18423 (heade3a22ebf) merged by the queue asb9598e9c(single-parent squash pergit rev-list --parents) at 2026-09-16T10:58:22Z — themerged_atinstant, carried identically by themergedandremoved_from_merge_queuetimeline events (added_to_merge_queue10:37:12Z). Two readings at 2026-09-16T11:02Z:origin/maintip isb9598e9c(test(hooks): pin guard-governed-enqueue's "no checkout available" fail-open (#18423)) and carries the new case (git greponorigin/main→ 1 hit in the selftest); the queue refgh-readonly-queue/main/pr-18423-*is gone. Governed landing by ruling C: ACCEPT 5695920970 (review of record), os-zhuang APPROVED 5221424219 on that head 10:23Z, ready + auto-merge + enqueue by the approver,--pair 184230 on the seat's side. This card closedcompletedbyFixesat 10:58:23Z. Residue (pm:dispatched, assignee) stripped throughlabel-write.mjsin the same stroke and read back. Hot-file chain released: #18384 is FREE on.claude/hooks/guard-governed-enqueue.sh+.selftest.shand is the next dispatch. Harness fact carried to the round report: the seat'sneeds-user-decisionremoval on PR #18423 was refused by the auto-mode classifier after the APPROVED was on it; the label stayed and did not gate the queue.
Generated by Claude Code
Filed by the
domain:skillsexecution PM seat, sessionsession_01HZfg2AwVX191qCizp88gQr, at 2026-09-16T04:27Z, from the #18321 dev'sout_of_scope_findings(report 5691990182 on #18321; PR #18365), measured by that dev and read by the seat.Reading
.claude/hooks/guard-governed-enqueue.sh's fail-open 「no checkout of the target repo is available to recompute its provenance on」 (warn + allow, after the governed predicate answered exit 3 with an exception row) is pinned by NO case inguard-governed-enqueue.selftest.sh, in any environment. The case whose comment used to claim it (「an exception-row path in a repo this container cannot resolve」) never reaches it: with nothing resolved the register is invoked WITHOUT--root, answers about THIS tree, whereskills/objectstack-data/references/_index.mdis byte-exact against its own generator and therefore LIFTED (exit 0), so the hook leaves at the cleared-predicateexit 0several branches above the fail-open, with EMPTY stderr. PR #18365 corrected that stale comment and made the case hermetic; it did not add coverage of the branch (a new fixture is a new verification surface — outside that card).The branch IS reachable:
node scripts/pm/check-governed-merges.mjs --test skills/zz-no-such-skill/references/_index.mdreturns exit 3 withexceptionsof length 1 (the generator 「does not write」 that path — it is not among the 9 declared outputs). That path shape, withOS_GOVERNED_ENQUEUE_SIBLING_ROOT(PR #18365) pointed at an empty directory, takes the fail-open and prints the warning.What is asked
One hermetic case in the selftest that reaches the fail-open (the path shape above + the injected empty root), asserting
allowAND the warning text (the dev's phantom-check lesson: a text assertion must be shown to go red under a firing control — e.g. the same payload with the sibling resolved)..claude/hooks/guard-governed-enqueue.selftest.shonly (the hook unchanged unless the case reveals a defect — report, do not widen); rules layer (.claude/hooks/**) ⇒ draft PR, four-piece + an authorized APPROVED; ⛔ never armed by the seat.Grading (lane self-triage; class (a), an unpinned branch): p3 · Task ·
pm:queue·domain:skills. SERIAL behind PR #18365 (the injection it uses). Fold candidate with the.git-slug card filed beside it (same two files; the second lander mergesorigin/mainotherwise).查重词
guard-governed-enqueue fail-open·no checkout available branch·target_root exception_rows·unpinned branch selftest·phantom checkGenerated by Claude Code