Repository navigation
[finding] driver-memory keeps a THIRD refusal wording for the same dateRange condition — the tree is at two wordings, not one, after #18232 #18277
Description
Activity
关
not_planned—— 维护者逐张复核 on-hold 卡时同意关闭;剩下的第二种措辞在冻结中的内存驱动里分诊席(
session_01Tw7jnJinGHvoGSi8aFkhPJ),2026-09-23T11:19Z。维护者 2026-09-23 在分诊会话里逐张复核pm:on-hold卡,对第九组的回复原文:「第九组 同意」。本卡在那一组里的建议是关闭。现状
{ field: {} }(零个操作符的字段约束)在同仓有三个答案:driver-sql 组合子内 TRUE、顶层抛 INVALID_FILTER、formula/driver-memory FALSE #5240 的约定:同一个条件只保留一种措辞(packages/spec/src/data/analytics.zod.ts的说明点名了「and the drivers」)。- PR fix(service-analytics): raise the ONE shared dateRange refusal wording #18275([finding] after #18230, service-analytics keeps a second refusal wording whose only stated justification is gone — the
#5240one-condition-one-wording convention #18232)已经去掉了service-analytics那一面的第二种措辞。 - 剩下的一处在内存驱动:
origin/main3ad89c1bcc上packages/drivers/driver-memory/src/memory-analytics.ts:779仍用自己的[driver-memory] dateRange …句子覆盖错误信息,错误码信封(ANALYTICS_DATE_RANGE_UNRECOGNIZED)不变。
为什么关
- 措辞不一致,但拒绝本身是响亮的、错误码是对的;
priority:p3。 driver-memory在维护者 2026-08-05 的投入冻结之内([裁决] driver-memory / driver-mongodb 投入冻结 —— 维护者 2026-08-05 口径（跨单锚点） #5499),今天同一族的多张卡按同一理由关闭。- 立卡时的去重控制没能命中已知的 [finding] after #18230, service-analytics keeps a second refusal wording whose only stated justification is gone — the
#5240one-condition-one-wording convention #18232,所以本卡没有去重结论;本席关闭时也没有另做去重搜索 —— 关闭不依赖它是否有重复。
给以后的人
若内存驱动的这一段因为别的原因被修改(或冻结解除),顺手照 PR #18275 的样子去掉本地覆盖,让它沿用共享的那一种措辞。
关闭理由:
not_planned,同时摘掉pm:on-hold。
Generated by Claude Code
Reported by the
domain:servicesdev that delivered #18275 (card #18232) as an out-of-scope finding, and filed here by the seat.The finding
packages/drivers/driver-memory/src/memory-analytics.tshas its own localexplicitDateRangeWindowthat overwriteserr.messagewith a[driver-memory]sentence — a third wording for the same condition, under the sameANALYTICS_DATE_RANGE_UNRECOGNIZEDenvelope.The rule it violates is quoted in
packages/spec/src/data/analytics.zod.ts's own prose, the#5240convention:Why it is filed NOW and what it means for #18232
PR #18275 removes the
service-analyticsface's second wording. ⇒ after it lands the tree is at TWO wordings for this condition, ⛔ not one. Card #18232 asked for the convention to hold, and it will not hold repo-wide until this one is closed too.⛔ It is not a defect in #18275, and ⛔ it was correctly not swept in:
packages/drivers/**is outside that card's declared file surface, and a one-off sweep from a card that does not own the package is how a shared convention gets moved sideways instead of forward.Class (b): the same declared invariant, violated the same way, in a different package.
Successor
Whoever holds
domain:engine/driver-memory. This is the exact sibling of the card just delivered, so the shape of the fix is already demonstrated in PR #18275.Dedupe words:
driver-memorymemory-analyticsexplicitDateRangeWindowthird wording#5240⛔ Ungraded on purpose, and ⛔ no
domain:label — the surface ispackages/drivers/**, which is not this seat's to route. Grading and routing are triage's.Generated by Claude Code