Repository navigation
app-showcase's nightly health sweep reaches its engine through a module-scope global, so it silently does nothing on an artifact-served boot #14257
Description
Activity
Triage (R+89, triage seat, session
session_019kDRpB7D2XzVzkaLp57T5D):pm:blocked·priority:p3·domain:engine· type Bug.Blocked-by: #14094
Why blocked, and why this lane: the fix reads
qlandloggeroffJobHandlerContext, which #14094 (dispatched, in flight in the engine lane) introduces — landing this first has nothing to bind to. Routed with #14094 so one implementer can carry the example app's rebinding as the follow-through; the unlock scan returns it topm:queuewhen #14094 closes. Lands in:examples/app-showcase/src/automation/jobs/sweep-project-health.ts+objectstack.config.ts(deletebindShowcaseJobRuntimeand itsonEnablecall, takeql/loggerfrom the argument, keepeffect: 'writes'), plus the handler's own test (fake context instead of fake host). p3 because it is the reference app, not a customer path — but it is the only shippeddefineJob, i.e. what an author copies, so it is not optional.Size/model suggestion: S,
sonnet/opus.
Generated by Claude Code
Unlock scan (R+90, triage seat, session
session_019kDRpB7D2XzVzkaLp57T5D): released →pm:queue. Blocker #14094 CLOSEDcompletedat 01:43:22Z via merged PR #14262.Card face re-verified on the merged ref (
origin/main=72adb7f):reading unblocker present JobHandlerContextdeclared inpackages/runtime/src/job-handler-context.ts, built atapp-plugin.ts:951✅ — soql/loggerare on the handler's argumentcard face examples/app-showcase/src/automation/jobs/sweep-project-health.ts:93still holdslet host: JobHostContext | undefined, withbindShowcaseJobRuntimeat:100⇒ holds — the shipped example still uses the pattern the fix supersedes⇒ Scope unchanged from this card's triage: take
ql/loggerfrom the argument, deletebindShowcaseJobRuntimeand itsonEnablecall, keepeffect: 'writes'on thefunctionsentry, swap the handler test's fake host for a fake context.
Generated by Claude Code
Found while implementing #14094. Independent of that card's fix, which lands in
packages/runtime; this one is the example app that still ships the pattern the fix supersedes.Measured
examples/app-showcase/src/automation/jobs/sweep-project-health.tsholds its engine handle in a module-scopelet host, filled by an exportedbindShowcaseJobRuntime(ctx)thatobjectstack.config.tscalls fromonEnable. Whenhostis unset the handler logsno engine handle bound yet — skipping this runand returns.That binding does not exist on the artifact path.
objectstack buildemitsfunctionsinto a sibling runtime module exporting only{ functions, meta }; the artifact JSON carries noonEnable, andmergeRuntimeModule(packages/runtime/src/load-artifact-bundle.ts) merges onlyfunctions. So on an artifact-served bootbindShowcaseJobRuntimeis never called,hoststaysundefined, andshowcase_health_sweepfires on schedule and recomputes nothing — reported as a clean run.Why it is worth fixing now
A scheduled job is one of the capabilities the showcase exists to demonstrate end to end, and #4774 / #4888 already had to repair this same job once for being declared-but-inert. It is also the only shipped
defineJobin the repo, so it is what an author copies.Shape of the fix
Since #14094 the job handler's context carries
qlandlogger(JobHandlerContext, exported from@objectstack/runtime). Take both from the argument, deletebindShowcaseJobRuntimeand itsonEnablecall, and keepeffect: 'writes'on thefunctionsentry.healthForis already engine-free and its unit test is unaffected; the handler's own test needs the fake host swapped for a fake context.Unassigned and untriaged.
Generated by Claude Code
Generated by Claude Code