Repository navigation
DEBT['@objectstack/metadata'] says errors: 89 while its note itemises 92 and says "Re-measured 92" — a second live instance of the #10174 class #10723
Description
Same class as #10174 (service-automation, being repaired now) and #7038 / #8982 (both already in a
closed state): a ledger
note narrating a state its own field contradicts. Filing rather than fixing — #10174's dispatch was
scoped to one entry with no count moves, and this is a different entry.
No behaviour is wrong; the note is. The ratchet is green either way.
Measured
scripts/check-type-check-coverage.mjs, DEBT['@objectstack/metadata'] at :411-417:
'@objectstack/metadata': {
errors: 89,
note: 'code-tier 34 (TS2345 x30, TS2322 x4); config-tier 24 (TS2835); noise 34 (TS7006 x33, TS6133). '
+ 'Re-measured 92 at 5ab08428, up from 87. Composition moved as well as the count: the note used to '
+ 'name TS2353, which is gone, and TS2322 has taken its place. Two thirds of the pile sits in '
+ 'metadata.test.ts (34) and register-notifies-watchers.test.ts (16).',
},- The tier itemisation sums to 34 + 24 + 34 = 92.
- The note states "Re-measured 92 at 5ab0842".
- The field states 89.
The note is internally consistent at 92; only the field disagrees. As with #10174, the entry was
evidently lowered 92 -> 89 without the note being rewritten alongside it.
It is stale, not history
A note may legitimately carry old numbers as narrative — TEST_DEBT['@objectstack/objectql'] recites
"Re-measured 333" while re-tallying correctly to its recorded 355, and that is fine. This entry is not
that: its current itemisation, the one describing the pile as it stands, is the thing that sums to 92.
Confirmed against a full --re-measure on a built closure (33 entries, 1912 raw errors) run tonight at
5757b74a35: the only surplus reported was @objectstack/plugin-auth (-12, tracked in #10615). So
@objectstack/metadata measures its recorded 89 exactly, and the note's 92 describes no tree.
Suggested fix
Re-measure the entry, rewrite the note to the measured tier composition, and record the 92 -> 89
graduation — mirroring what #10174 did for service-automation. Prose only, no count moves: 89 is
correct.
The mechanical cause of this whole class — --lower rewrites only the errors: digits and never the
note — and the proposal for a bounded check that would end it, are filed separately as #10722.
Generated by Claude Code
Generated by Claude Code
Activity
os-zhuang commentedon Aug 21, 2026
Triage (finding concentration round): promoted to
pm:queue· type Task. Prose-only note rewrite mirroring the #10174 repair, no count moves (89 is measured-correct; the note's 92 describes no tree). Serial (fold-or-serial answered): dispatch after #10174's PR lands — same file, same entry class — then #10722 (the mechanism fix) follows this card. Require a same-day re-measure at dispatch time before rewriting the tier composition. S,mode:subagent, sonnet; Clause-②: no.Generated by Claude Code
claude commentedon Aug 21, 2026
Claim — PM dispatch (devx seat)
c970724d-303c-5614-9d20-a3f92205cfadclaude/issue-10723-metadata-debt-noteSerial constraint cleared: PR #10721 (#10174), which held
scripts/check-type-check-coverage.mjs, merged at 2026-08-21T10:29:03Z.Premise re-verified on
origin/main=4b84834a32::412—errors: 89:413— the note itemisescode-tier 34+config-tier 24+noise 34= 92:414— "Re-measured 92 at 5ab0842, up from 87"Field says 89, note narrates 92, exactly as filed.
⭐ Which number is right is already established, and the dev should not re-litigate it. The
#10174 dispatch ran a full
check:type-check-debt --re-measuretonight and it reported exactlyone surplus entry (
plugin-auth) — so@objectstack/metadatameasures its recorded 89exactly. The note is the stale half, not the field.
⛔ No count moves. This is the same prose repair PR #10721 just landed for
@objectstack/service-automation— read that diff for the shape: rewrite the note to themeasured composition, record the drift direction, touch nothing else.
Related and deliberately not folded in: #10722 identifies the mechanical cause of this
whole class —
lowerLedgerEntries()rewrites only theerrors:digits and never the note, so--lower(which the gate's own surplus output recommends) mints a fresh instance every time itruns. And #10756, filed an hour ago, is about the same file's ledger completeness rather
than an entry's prose. Neither is this card's work.
Generated by Claude Code
claude commentedon Aug 21, 2026
{
"issue": 10723,
"status": "done",
"branch": "claude/issue-10723-metadata-debt-note",
"pr": "#10775",
"premise_still_valid": true,
"summary": "Rewrote DEBT['@objectstack/metadata']'s note to its measured composition;
errors: 89is untouched and no count moved. Re-measured with the gate's own invocation against a built closure at 4b84834: exactly 89, split code-tier 30 (TS2345 x30) / config-tier 25 (TS2835) / noise 34 (TS7006 x33, TS6133) — so the note's 34/24/34 = 92 was the stale half exactly as the card said, and the drift closes attributably tier by tier (-4 TS2322, +1 TS2835, noise flat = -3). Both inherited claims were re-derived rather than carried forward: the per-file counts (metadata.test.ts 34, register-notifies-watchers.test.ts 16) survive exactly, but the note's "two thirds" fraction never held at either endpoint — 50/89 is 56% and 50/92 was 54% — so the rewrite says "over HALF" and names both numbers it was wrong at. The residue is restated as three mechanical repairs rather than 89 problems: all 30 TS2345 are one mock PluginContext literal missing registerServiceFactory/getServiceScoped repeated across metadata.test.ts:608-945 (one fixture closes the whole code tier), and the 25 TS2835 are one .js-extension codemod spread over 12 files.","tests": "MEASUREMENT — the gate's own invocation (tscErrorCount()'s argv), from the repo root,\nagainst a built dependency closure, at base 4b84834 (= origin/main):\n\n $ ./node_modules/.bin/tsc --noEmit --pretty false -p packages/metadata/tsconfig.json\n -> exit 2 · 120 output lines · 89 matching the gate's own TSC_ERROR_LINE regex\n\nVALID, NOT A SILENT ZERO: TSC_SETUP_ERROR (TS5058|5083|6053|18003|5012|2688) matched 0\ntimes in the output, and the non-zero exit came WITH 89 recognisable diagnostics, so the\ngate's "exited non-zero but printed no recognisable diagnostics -- refusing to record 0"\nguard does not fire.\n\nTALLY — 89 = 33 + 30 + 25 + 1, in exactly 4 distinct diagnostic shapes:\n x33 TS7006 Parameter '…' implicitly has an 'any' type. [noise]\n x30 TS2345 Argument of type '…' is not assignable to parameter of type\n 'PluginContext'. [code]\n x25 TS2835 Relative import paths need explicit file extensions in ECMAScript\n imports when '--moduleResolution' is 'node16' or 'nodenext'. [config]\n x1 TS6133 'DatabaseLoaderOptions' is declared but its value is never read. [noise]\n TS2322: 0 occurrences — the old note itemised it at x4.\n\n => code-tier 30 · config-tier 25 · noise 34. The old note's 34 / 24 / 34 = 92 is the\n stale half; the field's 89 is correct, exactly as the card and the brief said.\n\nPER FILE (89): metadata.test.ts 34 · register-notifies-watchers.test.ts 16 ·\nmetadata-manager-cluster.test.ts 9 · metadata-service.test.ts 8 ·\nloaders/database-loader.test.ts 7 · metadata-history.test.ts 3 · plugin-hmr-reload.test.ts 3 ·\nserializers/serializers.test.ts 3 · metadata-realtime-events.test.ts 2 · plugin.test.ts 2 ·\nloaders/overlay-index-single-producer.test.ts 1 · utils/lru-cache.test.ts 1\n\nVERBATIM (head of the tsc log; full 120-line log at /tmp/claude-0/-home-user-objectstack/c970724d-303c-5614-9d20-a3f92205cfad/scratchpad/issue-10723/tsc-raw.log):\npackages/metadata/src/loaders/database-loader.test.ts(4,31): error TS6133: 'DatabaseLoaderOptions' is declared but its value is never read.\npackages/metadata/src/loaders/database-loader.test.ts(4,60): error TS2835: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './database-loader.js'?\npackages/metadata/src/loaders/database-loader.test.ts(6,33): error TS2835: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean '../metadata-manager.js'?\npackages/metadata/src/loaders/database-loader.test.ts(7,30): error TS2835: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './memory-loader.js'?\npackages/metadata/src/loaders/database-loader.test.ts(365,24): error TS7006: Parameter 'i' implicitly has an 'any' type.\npackages/metadata/src/loaders/database-loader.test.ts(366,24): error TS7006: Parameter 'i' implicitly has an 'any' type.\n\nHOMOGENEITY OF THE CODE TIER — verified, not assumed: 30/30 TS2345 carry the identical\nhead "is not assignable to parameter of type 'PluginContext'" and 30/30 carry the\nidentical continuation "missing the following properties from type 'PluginContext':\nregisterServiceFactory, getServiceScoped", at metadata.test.ts lines\n608 624 638 639 656 657 685 686 701 703 717 719 731 732 750 751 773 774 797 798 823 825\n847 848 878 879 904 905 944 945.\n\nGATES — derived with
node scripts/pm/dispatch-gates.mjswith NO paths (it self-derived\nthe change set: merge base 4b84834, 1 committed path, 0 working-tree, 0 untracked);\n4 families matched. All run at final commit 464fe41, quoting each gate's OWN verdict\nline (never a bare $?; each was captured by redirecting to a file before reading):\n\n check:type-check-coverage -> "check-type-check-coverage: OK — 64/77 workspace\n packages type-checked (plus the root), 13 in the DEBT ledger (436 frozen raw\n errors), 1 exempt." + self-test "23 semantic + 24 observation + 25 re-measure +\n 28 built-closure + 9 auto-lowering case(s) hold."\n\n check:type-check-debt (--re-measure) -> "check-type-check-coverage --re-measure: OK —\n 33 ledger entr(ies) re-measured in 277.1s, 1912 raw tsc error(s) total, none above\n its recorded number." @objectstack/metadata is NOT among the surplus entries —\n the gate's own independent confirmation that it measures its recorded 89 exactly.\n\n check:cross-package-test-inputs -> "OK: 13 package(s) read outside themselves, all\n declared, and turbo.json hashes every declared glob." + "All 90 self-test cases\n passed."\n\n check:nul-bytes -> "check-nul-bytes: OK (scanned 6235 text file(s) --\n 6235 tracked, 0 untracked-not-ignored; skipped 5 binary; no raw ASCII control\n bytes)." + self-test 75 assertions.\n\nFIRST RE-MEASURE ATTEMPT REFUSED CORRECTLY (reported as evidence the number came from a\nreal closure): "--re-measure cannot run: 43 workspace dependenc(ies) of the ledgered\npackages have no built type entry point on disk ... measuring now would not fail, it\nwould silently measure a DIFFERENT WORLD". Re-run after\npnpm exec turbo run build --filter='./packages/*' --filter='./packages/*/*'\n-> "Tasks: 70 successful, 70 total".\n\nONE INFORMATIONAL LINE, pre-existing and not this card's: @objectstack/plugin-auth\nTEST_DEBT records 109, tsc reports 97 (-12) — explicitly "Not an error", already owned by\n#6376 / #10615.\n\nMUTATION IS REAL — the anchor counts moved. This is prose inside a multi-line string\nconcatenation, where a zero-match edit reads as a clean no-op, so the replacement asserted\na match count of exactly 1 before writing, and repo-wide phrase counts across scripts/\nwere taken before and after:\n "Re-measured 92 at 5ab0842" 1 -> 0\n "code-tier 34 (TS2345 x30, TS2322 x4)" 1 -> 0\n "Two thirds of the pile" 1 -> 0\n "Re-measured 89 at 4b84834" 0 -> 1\n "Re-measured" (every ledger note) 30 -> 30 <- neighbour check: one swapped for\n one, so no other note moved\n entries named "@objectstack/metadata..." 13 -> 13\n git diff --stat: 1 file, +12/-4. Noerrors:line appears in the diff at all\n (git diff -U0 | grep -E '^[+-]\\s+errors:'is empty) — no count moved.\n\nNO ABLATION was run: this card is a prose rewrite of a ledger note, so there is no guard\nwhose failure could be demonstrated. Recording that explicitly rather than filling the\ntemplate's ablation slot with something that did not happen.\n\nNOTE TEXT BEFORE:\ncode-tier 34 (TS2345 x30, TS2322 x4); config-tier 24 (TS2835); noise 34 (TS7006 x33, TS6133). Re-measured 92 at 5ab0842, up from 87. Composition moved as well as the count: the note used to name TS2353, which is gone, and TS2322 has taken its place. Two thirds of the pile sits in metadata.test.ts (34) and register-notifies-watchers.test.ts (16).\n\nNOTE TEXT AFTER:\ncode-tier 30 (TS2345 x30); config-tier 25 (TS2835 x25); noise 34 (TS7006 x33, TS6133). Re-measured 89 at 4b84834, DOWN from 92 at 5ab0842 -- itself up from 87, so this entry has now drifted both ways. Against the composition recorded here at 92 the delta is attributable tier by tier: code-tier lost the 4 TS2322 (-4), config-tier gained one TS2835 (+1), noise did not move. TS2353 then TS2322 have each passed through the code tier and left; TS2345 x30 is its only lasting resident. Read the 89 as three mechanical repairs, not 89 problems: all 30 TS2345 are one defect thirty times over, in metadata.test.ts between 608 and 945, every one the same mock PluginContext literal missing registerServiceFactory and getServiceScoped, so one shared fixture closes the code tier outright; the 25 TS2835 are the widest spread (12 files) and are one codemod, a relative import wanting an explicit .js extension under node16 resolution. metadata.test.ts (34) and register-notifies-watchers.test.ts (16) do still hold 50 of the 89, but that is over HALF -- the "two thirds" claimed here was true at neither 92 nor 89.\n\nOUT-OF-SCOPE SWEEP: one candidate examined and dismissed rather than filed — the\nempty-import-metaesbuild warnings from driver-sqlite-wasm's CJS build are deliberate\nand documented at the source (knex-wasm-dialect.ts carries the comment "import.meta.url\nis replaced with an empty string in CJS output; fall back to the current file/cwd in that\ncase" and a real __filename/cwd fallback), so it is handled behaviour, not a defect.\nGrepped 324 open issues for sqlite-wasm / import.meta titles: 0 hits, consistent with\nthere being nothing to file. Nothing else in scope drifted.\n","open_questions": [],
"out_of_scope_findings": []
}
Generated by Claude Code