Repository navigation
[finding] create-objectstack's content/** rationale describes a read that moved — the glob is held by a git grep, not by doc frontmatter #10694
Description
Activity
Triage (finding concentration round, 2026-08-21, seat grading):
finding→pm:on-hold. Reason: the accurate holder statement already sits in the file directly beside the stale rationale (PR #10690'sheldBycomment), so no reader is misled into deleting the glob; what remains is a rationale rewrite that the card itself says wants its own measurement of whattemplate-consistency.test.tsjustifies today — the classic touch-it-when-you're-there fix.Restart-touch: scripts/check-cross-package-test-inputs.mjs
On restart (next dispatch touching that file): fold the rationale rewrite in as a declared rider — measure the test's current
content/reads first, per the card.
Generated by Claude Code
Hold made legal — opportunistic trigger, deliberately shared with #10315
devx lane PM, session
session_01PfaSTikked61BkcsB5Rn69, round 13. Authorization: maintainer instruction this session to clear the eight illegalpm:on-holdcards flagged by half-state patrol H9.Held with no
Restart-when:in either channel — illegal. This is the cheapest card in the sweep and the one an opportunistic trigger fits best: a stale rationale sentence, no gate red, and the accurate reading already sitting beside it in the file.Restart-when: anyone opens scripts/check-cross-package-test-inputs.mjs for another reason — this is a comment repair that should ride that visit, never its own dispatch. One-line predicate: a PR touches scripts/check-cross-package-test-inputs.mjs. Restart-touch: scripts/check-cross-package-test-inputs.mjsVerified on
origin/main: the file still exists and still carries thecreate-objectstackentry, so the trigger is real.⚠️ ThisRestart-touchintentionally matches #10315's. Both cards wake on the same file, which is correct: the next person in there gets one cheap prose fix (this card) and one design question (#10315) for a single context load. ⛔ Neither is a reason to open that file on its own.⭐ Why it stays a hold rather than a queue item: the harm is already bounded. PR #10690 added a
heldBycomment directly below the stale sentence stating the real holder, so the accurate reading is present in the file — a reader gets the truth beside the drift rather than only the drift. What is left is reconciling the two, and the card is right that this "wants its own measurement of whattemplate-consistency.test.tsjustifies today, not a rider".The measured facts, so a future visit does not re-derive them: the only thing reaching
content/is the skills-catalog-boundarygit grepat:495; thefrontmatterOf(...)reads are driven bygit ls-files '*SKILL.md'and are about skills, not templates; andgrep -n 'content/'over the whole file returns exactly one line. The glob is real — the sentence explaining it is not.
Generated by Claude Code
关
not_planned—— 维护者逐张复核 on-hold 卡时同意关闭;纯开发工具卡分诊席(
session_01Tw7jnJinGHvoGSi8aFkhPJ),2026-09-23T09:15Z。维护者 2026-09-23 在分诊会话里逐张复核pm:on-hold卡,对第五组的回复原文:「10164 不考虑旧的;11182 当前版本就优先处理,统一为cel;其他同意」。 本卡在那一组里的建议是关闭。呈给维护者的事实
-
scripts/check-cross-package-test-inputs.mjs里create-objectstack那一条的注释理由已经过时。正确的说明(PR fix(scripts): ask the per-GLOB holder question, and stop counting the seeds in prose #10690 加的heldBy注释)就写在它正下方,不会误导读者。没有门禁变红。 -
本卡是
tooling,对产品没有影响。SKILL.md:374:产品仓的 P0/P1 开着时,没有解锁对象的 p2/p3tooling卡一律关闭。
卡面的测量和设计笔记原样保留;重开是免费的。
关闭理由:
not_planned,同时摘掉pm:on-hold。
Generated by Claude Code
-
Observation-class, measured while building the per-glob holder limb in PR #10690. No gate is red today. Filed unassigned, no
pm:queue. Same class as #10565: prose inscripts/check-cross-package-test-inputs.mjsthat lags the code it describes.Measured on
844bf29a84CROSS_PACKAGE_TEST_INPUTS['create-objectstack']opens with:That sentence is the stated justification for the
content/**glob. In today'spackages/create-objectstack/src/template-consistency.test.ts:content/is the skills-catalog-boundary block, which runsgit grep -nF 'skills add objectstack-ai/objectstack' -- content/docs skills packages/create-objectstack …(:495);frontmatterOf(path.join(repoRoot, rel))reads are driven bygit ls-files '*SKILL.md', so they are about skills, not about templates, andinternalthere ismetadata.internalon a SKILL.md;grep -n 'content/'over the whole file returns exactly one line, the pathspec above.So the glob is real — a
content/docspage really can flip that assertion — but the sentence explaining it describes a templates-internal decision that no longer readscontent/at all. Drift in the benign direction again (the declaration is right, the rationale is not), which is why nothing caught it.Why record it rather than reword it in passing
PR #10690 was scoped to the per-glob limb plus the "two seeds" sites #10565 names, and it now states the real holder in the
heldBycomment it adds right below this sentence — so the accurate reading is present in the file, beside the stale one. Reconciling the two is a rationale rewrite that wants its own measurement of whattemplate-consistency.test.tsjustifies today, not a rider.Refs
#10565 (the sibling prose drift, same file) · #10566 · PR #10690
Generated by Claude Code