Repository navigation
docs(changelog): repoint the eight links ADR-0130's package move left dead - #2033
Merged
objectstack-fleet[bot] merged 1 commit intoOct 9, 2026
Merged
Conversation
… dead Link Check has been red on every push to main since 36b27dd (#1910, 2026-09-14): the push run scans every .md file, and CHANGELOG.md's closed pre-3.0.0 section still linked eight files at the flat src/<kind>/ paths the package move renamed. Each target now names the file's package home (git log --follow: every one is a pure rename in 36b27dd). Only the link targets change - the record keeps its words, including the two link texts that spell the old path, per #1932's keep-the-record, repoint-the-pointer rule. Claude-Session: https://claude.ai/code/session_012zh91QzFgePbkmuHnugLN3 Co-authored-by: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2030
Clause-②: no
What was wrong, measured at the door
Link Checkconcludedfailureon every push tomainfrom36b27dd8(the ADR-0130 package move, #1910, 2026-09-14T14:07Z) onward — the previous push,3118ccff, was green — and on every weekly scheduled run since (2026-09-21, 09-28, 10-05). The card measured it from 2026-10-03; the real start is 25 days earlier.The push run scans every
.mdfile (folder-path: '.',check-modified-files-only: no). It was reproduced locally with the workflow's own tool before anything changed:gaurav-nelson/github-action-markdown-link-check@v1(tag peels to5c5dfc0, which installsmarkdown-link-check@3.8.7), the samefind . -name '*.md' -not -path './node_modules/*' -exec markdown-link-check {} --config .github/markdown-link-check-config.json -q ';'over agit archiveof08cfa209(932 files = 932 tracked, 120.md):One
ERROR:block across all 120 files, and it is byte-for-byte the block in CI job113435449891(run37813318528,main08cfa209), whose scanned-file list is the same 120 files.Proxy refusals told apart from dead links. The container's egress proxy answers
403toCONNECTfor 9 hosts these files link (keepachangelog.com,semver.org,docs.objectstack.ai,objectstack.ai,cloud.objectos.app,fumadocs.dev,nextjs.org,www.conventionalcommits.org,img.shields.io), and answers its own "GitHub access to this repository is not enabled for this session"403for two GitHub repos (changesets/changesets,fuma-nama/fumadocs). Those are refusals, not verdicts: locally they are NOT MEASURED, and CI's log above — open network, same commit — passes every one of them. Everything the proxy does reach was checked by the tool itself (37github.comURLs, all200).The change, and why it is the minimal one
All eight targets still exist;
git log --followshows each is a pure rename in36b27dd8(R100;quote.hook.tsR099). So each link target now names the file's package home, and nothing else in the release history moves:src/objects/opportunity.hook.tssrc/sales/objects/opportunity.hook.tssrc/objects/quote.hook.tssrc/revenue/objects/quote.hook.tssrc/dashboards/executive.dashboard.ts(3 links)src/sales/dashboards/executive.dashboard.tssrc/dashboards/crm.dashboard.ts(3 links)src/sales/dashboards/crm.dashboard.tssrc/dashboards/sales.dashboard.tssrc/sales/dashboards/sales.dashboard.tssrc/dashboards/service.dashboard.tssrc/service/dashboards/service.dashboard.tssrc/flows/opportunity-approval.flow.tssrc/sales/flows/opportunity-approval.flow.tssrc/sharing/account.sharing.tssrc/sales/sharing/account.sharing.ts](…)target masked,HEAD~1andHEADhash identically (97cca8ec…), and the byte delta (+76) is exactly the 12 inserted package segments.src/flows/opportunity-approval.flow.ts,src/sharing/account.sharing.ts) and the prose code spans naming old paths: that is docs: keep the record, repoint the pointer — the ADR-0130 dead paths in docs/, scripts/ and the root configs #1932's rule — a record keeps where something WAS, a pointer a reader follows must be current. The section's "Nothing is added here" holds: nothing is added..changeset/2030-changelog-dead-links.mdwith empty frontmatter — the package is private, and these lines sit in a section no release reads (publish-marketplace.mjssends only the published version's own section), so this releases nothing to users (AGENTS.md's exception, on docs: keep the record, repoint the pointer — the ADR-0130 dead paths in docs/, scripts/ and the root configs #1932's precedent).What pins it
No new test: AGENTS.md rule 3 (no gate farm) and a widened gate is the maintainer's call. The pin is the existing
Link Checkjob: this PR modifiesCHANGELOG.md, so this PR's own modified-files run re-reads it, and the nextmainpush re-reads every.md. Measured locally on5233301ewith the same tool: 121 files (the new changeset is the 121st), 0ERROR:blocks,FILE: ./CHANGELOG.md→46 links checked., both with the network masked and through the proxy with only the refused targets above masked.pnpm verifyon5233301e: exit 0 —✓ Validation passed, typecheck,os lint --strict(18 suggestions, 0 errors),✓ i18n lint gate: 0,✓ source hygiene clean, token ratchet all✓,✓ Build complete,Test Files 172 passed (172),Tests 3575 passed | 1 skipped (3576).Acceptance notes
pull_requestrun usescheck-modified-files-only, so a PR that moves a file never re-checks the unchanged.mdthat links to it. Measured: refactor(layout): a directory under src/ is a package — move every authored file into sales / service / revenue / marketing #1910's heade06226c5gotLink Check=success(run34831104903); its merge went red. A second leg, read from the workflow and not measured: bothpushandpull_requestare path-filtered to**/*.md/**/*.mdx, so a move that touches no.mdruns no link check at all until the Monday schedule. The scan scope is unchanged in this PR; the proposed patch is in the dev report on the card.test/docs-src-tree-paths.test.tsdoes not readCHANGELOG.md. That is consistent with docs: keep the record, repoint the pointer — the ADR-0130 dead paths in docs/, scripts/ and the root configs #1932's records-keep-their-path rule (it checks directory claims, not link targets); noted, not changed.Generated by Claude Code