Repository navigation
docs(zh-Hant): name the Setup app in English where it had no arrow - #1560
Merged
Merged
Conversation
Seven sites on five zh-Hant pages spelled the Setup app 設定 with no arrow, a shape all three rules of test/docs-setup-navigation-names.test.ts are structurally unable to see: rule 1 bans only names the platform ships nowhere, and 設定 is both a live zh-CN label and the ordinary Chinese word for "configure"; rules 2 and 3 need a bold **App → …** path. Three of the seven contradicted themselves inside one sentence, spelling the app 設定 and then citing a path through it in English on the same line. Every replacement is the label the page's English twin already uses, taken verbatim: "this tenant's Setup", "what Setup does ship", "Setup ships no SCIM screen", "not at Setup", and "not on a Setup screen". A denial stays a denial — only the app name changes. All 297 occurrences of 設定 across the 67 zh-Hant pages were graded. The other 290 are correct prose — 權限設定檔 (Profile), 設定變更 / 設定項, the verb itself, the docs site's own page titles and cross-links, and the three 設定頁 on guides/email-and-calendar that describe a Settings page the twin marks (not shipped). Prose only. No guard change: whether any rule can catch this shape is an open question tracked separately, and the guard is green before and after here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019hUuCQStzXGMFSX4dzww5t
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
os-sales
marked this pull request as ready for review
September 3, 2026 11:55
This was referenced Sep 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1538
Seven sites on five zh-Hant pages spelled the Setup app 設定 with no arrow. Every replacement is the label the page's English twin already uses, taken verbatim rather than translated back. A denial stays a denial — only the app name changes.
The seven sites, with the twin string each one took
administration/sandbox-and-releases.zh-Hant.mdx:44administration/sandbox-and-releases.zh-Hant.mdx:155reference/performance-and-limits.zh-Hant.mdx:297reference/security-and-compliance.zh-Hant.mdx:75administration/setup.zh-Hant.mdx:112service/sla-and-escalation.zh-Hant.mdx:33service/sla-and-escalation.zh-Hant.mdx:162Three of the seven were self-contradicting inside a single sentence, spelling the app 設定 and then citing a path through it in English on the same line.
The three judgement-call lines resolved the same way: change
administration/setup.zh-Hant.mdx:112andservice/sla-and-escalation.zh-Hant.mdx:33/:162read as generic ("any settings screen") on their own, and #1538 left them open on purpose. All three twins settle it: each writes a Setup screen with a capital S, on pages whose neighbouring sentences use the same word as the app (There is no Setup → Lead Settings screen,there is no Setup → Opportunity → Stages page,Neither recipient list is configurable on a Setup screen). The generic sense is spelled differently in the same files and is left alone — the twin of 「租戶級的營業時間設定」 is lowercase "no tenant business-hours setup behind it", and the verb 設定 in 「在介面裡能設定的是 SSO」 is "SSO is the part you configure in the UI".The graded sweep — all 297 occurrences, not just the place form
設定 is also the ordinary Chinese word for configure, so a raw count is not a finding. Every occurrence of 設定 across the 67 zh-Hant pages was graded — 297 occurrences, and the eight below are the whole defect class. (工作室, for Studio: 0 occurrences, so the Studio app is never named in Chinese on this surface.)
guides/email-and-calendar.zh-Hant.mdx:56/62/64, twin Settings → Email Templatesconfig_change記錄」sandbox-and-releases:44carries two87 + 187 + 8 + 3 + 1 + 1 + 8 + 2 = 297.
Measurements
test/docs-setup-navigation-names.test.ts— 1 file, 18 tests passed on the untouched tree, and 18 tests passed on the edited tree. That is the expected result: rule 1 bans only names the platform ships nowhere, and 設定 is both a livezh-CNlabel and an ordinary word, so it can never be listed there; rules 2 and 3 need a bold**App → …**path and this shape has no arrow. The guard going red here would have meant Four more zh-Hant sites name the Setup app in Chinese with no arrow — a shape all three rules of the navigation guard are structurally unable to see #1538's model was wrong.pnpm verifygreen atb0496914— the full chain,validate && typecheck && lint && lint:i18n-gate && hygiene && hygiene:tokens && build && test:✓ Validation passed (1577ms)·tsc --noEmitclean ·objectstack lintclean ·✓ i18n lint gate: 0 i18n/missing-* issues·✓ source hygiene clean·✓ source token ratchet clean·✓ Build complete (2185ms)· Test Files 159 passed (159), Tests 3344 passed | 1 skipped (3345).Two things the card had slightly wrong, reported not corrected in place
reference/security-and-compliance.zh-Hant.mdx, notadministration/. Four more zh-Hant sites name the Setup app in Chinese with no arrow — a shape all three rules of the navigation guard are structurally unable to see #1538 and its dispatch claim both nameadministration/security-and-compliance.zh-Hant.mdx; no such file exists. The site itself is real and matches the quoted text exactly. This matters for the fence the claim declares over Security page's zh siblings call two-factor 「双因素」, but the platform's zh-CN pack says 「两步验证」 #1514 — the fence holds, on thereference/path.reference/security-and-compliance.zh-Hans.mdx:75reads 「设置里没有 SCIM 页面。」. That is out of this claim's surface, and it is not obviously a defect at all: 设置 is what the console actually renders for a Simplified reader, so a Simplified page naming a Simplified-rendered app in Chinese is the convention working, not failing. Left for whoever rules on it.Not in scope here
No guard change. Whether any rule can catch this shape at all is #1553, which stays open — a rule keyed on the place form would have to survive the ~289 correct generic uses graded above, and nothing here shows that it can.
Two further sites are in the same class but outside this PR's declared file surface, and are filed as #1559: 「設定 UI」 on
administration/index.zh-Hant.mdx:40(twin: Setup UI), and the Setup app's nine navigation groups still listed in Traditional onguides/integrations.zh-Hant.mdx:33— the same roster PR #1537 converted on the other page that carries it, where the sixth entry 設定 names Configuration, not Setup.🤖 Generated with Claude Code
https://claude.ai/code/session_019hUuCQStzXGMFSX4dzww5t