Skip to content

content/docs/guides/email-and-calendar.mdx 的 "Log a Call" 段仍描述 #592 之前的写入行为(只写 sys_activity,没有 event/参会人) #738

Description

@yinlianghui

发现于 #672 / PR #737 的实施过程中(该 PR 的文件面只允许新增页面,不允许改既有 docs 页),故单独记录。

现状

content/docs/guides/email-and-calendar.mdx:74:

The Log a Call action records an outbound or inbound call without leaving the record. On submit, an entry of type completed is written to sys_activity (kind = call), with subject, duration and outcome. It appears on the record's Activity tab and is counted in the rep's activity metrics on the Sales / Service dashboards.

这正是 #592 / PR #670 修掉的那个旧行为。当前落地的 log_call(src/actions/global.actions.ts)一次写三样东西:

  1. 一条真实的 crm_event(主题、类型、状态 held、开始时间、时长、地点、备注、负责人、related_to_* 关联);
  2. 若干条 crm_event_attendee(发起人为组织者,回复 accepted;联系人/线索目标记录自身;表单选中的联系人与同事);
  3. sys_activity 仅作为统一时间线的指针(ADR-0052 source_object='crm_event' / source_id),metadata 里不再塞参会人名单。

同段还有两处需要一并核实(本 issue 未下结论):

  • 「counted in the rep's activity metrics on the Sales / Service dashboards」——活动指标现在由 event_metrics 数据集驱动,落在 Sales Activity 仪表盘上(src/dashboards/activity.dashboard.ts);Sales / Service 两个仪表盘是否真有活动 tile 需按元数据逐条核对。
  • 该页的 "Calendar sync"、"Email tracking"、"Inbound case email" 等段落描述的是连接器能力,仓库里是否有对应元数据支撑,同样需要核对——本仓库的文档哲学是「文档描述已落地行为」。

建议

改写 "Log a Call" 段,指向新落地的 content/docs/sales/meetings-and-calls.mdx(PR #737 新增,含 zh-Hans / zh-Hant),避免同一件事在两页各说一套;顺带处理上面两条核实项。三个语言版本同改。

注意:PR #737 新增的 test/docs-object-coverage.test.ts 不检查这一页——它只保证「每个 crm_* 对象都有一页用户文档」,散文里的事实断言不在它的射程内。这类「散文描述与落地行为不符」目前仍无门禁覆盖。

Activity

  1. added
    bugSomething isn't working
    documentationImprovements or additions to documentation
    pm:queueReady for the PM dispatch loop
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Aug 5, 2026
  2. self-assigned this
    on Aug 5, 2026
  3. yinlianghui commented on Aug 5, 2026

    @yinlianghui
    CollaboratorAuthor

    认领:PM 循环(17.0 发布修复线)第 6 轮
    会话:session_01VHrPAGEgFDoHjphqYG4BMa
    分支:claude/issue-738-email-calendar-log-call
    Worktree:hotcrm-issue-738
    文件面:content/docs/guides/email-and-calendar.mdx(+zh 页若存在)、changeset。⛔ 不动 sales/ 下各页(#752 同轮在飞于 opportunities.mdx)。

    派发注记:以 #737 落地的 meetings-and-calls 页与 src/ 实测为准修正 Log a Call 段(#592 后写 event + attendee + sys_activity 指针);正文列的另两处待核实项(仪表盘活动指标、连接器能力段)逐一实测后同 PR 处理或说明不改的理由。


    Generated by Claude Code

  4. yinlianghui commented on Aug 5, 2026

    @yinlianghui
    CollaboratorAuthor

    验收 ACCEPT(PM 复核,对照 GitHub 实况):PR #755,关键检查全绿,已转 ready 并挂自动合并。

    复核要点:


    Generated by Claude Code

  5. added and removed on Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdocumentationImprovements or additions to documentationpm:dispatchedDispatched to a dev agent by /pm-dispatchpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions