Skip to content

Un-wire the known-broken mass_update_stage bulk button until #508 lands #588

Description

@os-zhuang

Follow-up scoping decision on #508, from the 2026-08-02 review.

Problem

mass_update_stage is documented KNOWN-BROKEN in its own source (src/actions/opportunity.actions.ts:661-670: "kept wired and tracked in issue #508. No invocation path currently executes it.") — yet it is still listed in bulkActions on the opportunity list view (src/views/opportunity.view.ts:77).

Net effect for a real user: the button renders, is clickable, and silently does nothing. That is worse than the button being absent — it reads as data loss / product breakage, not as a tracked platform gap.

Fix

Acceptance

Activity

  1. added
    bugSomething isn't working
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed on Aug 2, 2026
  2. self-assigned this
    on Aug 2, 2026
  3. os-zhuang commented on Aug 2, 2026

    @os-zhuang
    ContributorAuthor

    认领:PM 循环第 1 轮
    会话:session_019SS7C5SXpniKeCApxgARyf
    分支:claude/issue-588-dead-bulk-button
    Worktree:hotcrm-issue-588


    Generated by Claude Code

  4. os-zhuang commented on Aug 2, 2026

    @os-zhuang
    ContributorAuthor

    ✅ 验收通过(PM 循环第 1 轮):PR #609 已启用合并队列自动落地。

    交付内容:mass_update_stage 从 opportunity 列表视图的 bulkActions 下架(该按钮零网络请求却弹「成功」,是最坏的静默失败形态);action 定义、翻译、参数全部保留,恢复只需一行(注释已写明恢复条件 = 关闭 #508 的同一个 PR);新增 BULK_INVOCATION_DEAD 注册表 + 双向守卫——死按钮不能悄悄回来,下架也不能退化成删除。CI 9/9 全绿。


    Generated by Claude Code

  5. added
    priority:p0Critical: blocker, must ship before MVP
    and removed on Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpm:dispatchedDispatched to a dev agent by /pm-dispatchpriority:p0Critical: blocker, must ship before MVP

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions