Sre 2645 added more loging #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chacon
suggested changes
Jan 14, 2019
| # wait for replication to get in sync | ||
| while state.get('last_ts') and state.get('last_ts') < timestamp: | ||
| # wait for replication to get in sync making sure cursor has not been stopped in a race condition | ||
| while state.get('last_ts') and state.get('last_ts') < timestamp and not self.shards[shard]['thread'].stopped: |
There was a problem hiding this comment.
Seems like the first condition is unnecessary if the second depends on it anyway.
chacon
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended up not using oplog trailer feature at all on our instances so that code is not working in production. All other changes are additional logging