feat(#412): removed the empty object warning for lambda objects #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h1alexbel please, review this one |
h1alexbel
suggested changes
Mar 17, 2025
| @@ -0,0 +1,15 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com | |||
There was a problem hiding this comment.
@Marat-Tim let's rename this pack to allows-lambda-object-in-atom.yaml
| <xsl:import href="/org/eolang/funcs/lineno.xsl"/> | ||
| <xsl:import href="/org/eolang/funcs/escape.xsl"/> | ||
| <xsl:output encoding="UTF-8" method="xml"/> | ||
| <xsl:template match="/"> | ||
| <defects> | ||
| <xsl:for-each select="/program/objects//o[not(@base) and not(o) and not(eo:atom(.))]"> | ||
| <xsl:for-each select="/program/objects//o[not(@base) and not(o) and not(eo:atom(.)) and not(@name=$eo:lambda)]"> |
There was a problem hiding this comment.
@Marat-Tim we also should check that object with @name=$eo:lambda is placed inside the atom. Currently it is legal to have such XMIR (we need to complain instead):
<program>
<objects>
<o name="λ"/>
</objects>
</program>@name="λ" should be allowed only inside atom. The following XMIR should be warning-free:
<program>
<objects>
<o name="name">
<o name="λ"/>
</o>
</objects>
</program>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be in the eo repository in the file https://github.com/objectionary/eo/blob/master/eo-parser/src/main/resources/org/eolang/parser/_funcs.xsl there is a problem with the atom function, as it checks that the nested one, not the current one, has the name
lambda