Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

released EO-hamcrest 0.3.2 and EO-collections 0.0.8 and EO-strings 0.2.0 #116

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

Graur
Copy link
Contributor

@Graur Graur commented Mar 6, 2023

I tried to merge these changes separately but they are failed. So, I decided to merge them together and fix implementation of text.contains which was the main reason of the failed build and had a very slow computing.

What's done:

  • updated code according to new versions of EO-hamcrest 0.3.2 and EO-collections 0.0.8 and EO-strings 0.2.0
  • updated implementation of text.contains. Now it doesn't break tests. Similar implementation was introduced here: make text.contatins faster eo-strings#143
  • disabled 4 tests in eo-sys. We need to release this package in near future

@Graur Graur changed the title EO-hamcrest 0.3.2 released EO-hamcrest 0.3.2 and EO-collections 0.0.8 and EO-strings 0.2.0 Mar 6, 2023
@Graur Graur marked this pull request as ready for review March 7, 2023 09:19
@yegor256
Copy link
Member

yegor256 commented Mar 7, 2023

@volodya-lombrozo pls, take a look

make/jvm/pom.xml Outdated Show resolved Hide resolved
@Graur
Copy link
Contributor Author

Graur commented Mar 7, 2023

@volodya-lombrozo Please, take a look

Copy link
Member

@volodya-lombrozo volodya-lombrozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Graur Looks good to me. Thanks.
@yegor256 Could you merge that changes, please?

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@yegor256
Copy link
Member

yegor256 commented Mar 8, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 8, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4e448bb into objectionary:master Mar 8, 2023
@rultor
Copy link
Contributor

rultor commented Mar 8, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 15min)

@Graur Graur deleted the eo-hamcrest-0-3-2 branch March 8, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants