-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#3461): Use Expect for EOnumber Atoms #3789
Merged
yegor256
merged 9 commits into
objectionary:master
from
asmirnov-backend:feat/#3461/use-expect-for-some-atoms
Jan 25, 2025
Merged
feat(#3461): Use Expect for EOnumber Atoms #3789
yegor256
merged 9 commits into
objectionary:master
from
asmirnov-backend:feat/#3461/use-expect-for-some-atoms
Jan 25, 2025
+82
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmirnov-backend
changed the title
[WIP] feat(#3461): Use Expect for some Atoms
[WIP] feat(#3461): Use Expect for EOnumber Atoms
Jan 7, 2025
asmirnov-backend
force-pushed
the
feat/#3461/use-expect-for-some-atoms
branch
from
January 16, 2025 09:02
644e0bb
to
c4b4c5e
Compare
asmirnov-backend
force-pushed
the
feat/#3461/use-expect-for-some-atoms
branch
from
January 19, 2025 09:13
1ba2bd1
to
d7f02b1
Compare
| refactor: use Expect.Number
| refactor: use Expect.Number
asmirnov-backend
force-pushed
the
feat/#3461/use-expect-for-some-atoms
branch
2 times, most recently
from
January 25, 2025 14:01
ab827fc
to
cadf1b9
Compare
asmirnov-backend
force-pushed
the
feat/#3461/use-expect-for-some-atoms
branch
from
January 25, 2025 14:05
cadf1b9
to
2a9b19d
Compare
@yegor256 Could you please take a look |
asmirnov-backend
changed the title
[WIP] feat(#3461): Use Expect for EOnumber Atoms
feat(#3461): Use Expect for EOnumber Atoms
Jan 25, 2025
yegor256
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asmirnov-backend looks good!
@asmirnov-backend thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3461
Use Expect for: