Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3461): Use Expect for EOnumber Atoms #3789

Conversation

asmirnov-backend
Copy link
Contributor

@asmirnov-backend asmirnov-backend commented Jan 7, 2025

Ref: #3461

Use Expect for:

  • EOnumber$EOplus
  • EOnumber$EOas_i64
  • EOnumber$EOdiv
  • EOnumber$EOgt
  • EOnumber$EOfloor

@asmirnov-backend asmirnov-backend changed the title [WIP] feat(#3461): Use Expect for some Atoms [WIP] feat(#3461): Use Expect for EOnumber Atoms Jan 7, 2025
@asmirnov-backend asmirnov-backend force-pushed the feat/#3461/use-expect-for-some-atoms branch from 644e0bb to c4b4c5e Compare January 16, 2025 09:02
@asmirnov-backend asmirnov-backend force-pushed the feat/#3461/use-expect-for-some-atoms branch from 1ba2bd1 to d7f02b1 Compare January 19, 2025 09:13
@asmirnov-backend asmirnov-backend force-pushed the feat/#3461/use-expect-for-some-atoms branch 2 times, most recently from ab827fc to cadf1b9 Compare January 25, 2025 14:01
@asmirnov-backend asmirnov-backend force-pushed the feat/#3461/use-expect-for-some-atoms branch from cadf1b9 to 2a9b19d Compare January 25, 2025 14:05
@asmirnov-backend asmirnov-backend marked this pull request as ready for review January 25, 2025 14:06
@asmirnov-backend
Copy link
Contributor Author

@yegor256 Could you please take a look

@asmirnov-backend asmirnov-backend changed the title [WIP] feat(#3461): Use Expect for EOnumber Atoms feat(#3461): Use Expect for EOnumber Atoms Jan 25, 2025
@yegor256 yegor256 enabled auto-merge January 25, 2025 15:36
Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmirnov-backend looks good!

@yegor256 yegor256 added this pull request to the merge queue Jan 25, 2025
@yegor256
Copy link
Member

@asmirnov-backend thanks!

Merged via the queue into objectionary:master with commit 6b6ba6b Jan 25, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants