Skip to content

Conversation

@volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented May 10, 2023

Make tests in eo-runtime run in parallel.
PhLocated isn't intended to work with multiple compilations simultaneously. Therefore, in order to run it in parallel, we need to make its internal components ThreadLocal.

Tests execution time

  • Before: 14.808 s
  • After: 10.289 s

Closes: #2014


PR-Codex overview

This PR makes several changes to the codebase, including introducing ThreadLocal variables to improve concurrency and fixing a bug in the Vertices class.

Detailed summary

  • Introduces ThreadLocal variables for Heaps, PhPackage, and Vertices classes to improve concurrency.
  • Fixes a bug in the Vertices class where the primitive method was not being called correctly.
  • Updates the EOheap class to use the new Heaps implementation.
  • Updates the PhPackage class to use the new ThreadLocal implementation.
  • Adds a new test to ensure that attributes can be found concurrently.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo volodya-lombrozo requested a review from Graur May 23, 2023 14:18
@volodya-lombrozo
Copy link
Member Author

@Graur Could you have a look, please?

@volodya-lombrozo volodya-lombrozo marked this pull request as ready for review May 23, 2023 14:18
@Graur
Copy link
Contributor

Graur commented May 23, 2023

@volodya-lombrozo Looks like this flaky test failed. Maybe it would be better to run these checks again?

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you merge that changes, please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 24, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 93d9635 into objectionary:master May 24, 2023
@rultor
Copy link
Contributor

rultor commented May 24, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pom.xml:107: Enable parallel run of all tests in...

5 participants