-
Notifications
You must be signed in to change notification settings - Fork 176
feat(#2014): Make tests in eo-runtime run in parallel
#2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rultor
merged 13 commits into
objectionary:master
from
volodya-lombrozo:2014_parallel_runtime_tests
May 24, 2023
Merged
feat(#2014): Make tests in eo-runtime run in parallel
#2055
rultor
merged 13 commits into
objectionary:master
from
volodya-lombrozo:2014_parallel_runtime_tests
May 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Graur Could you have a look, please? |
Contributor
|
@volodya-lombrozo Looks like this flaky test failed. Maybe it would be better to run these checks again? |
Graur
approved these changes
May 24, 2023
Member
Author
|
@yegor256 Could you merge that changes, please? |
Member
|
@rultor merge |
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make tests in
eo-runtimerun in parallel.PhLocatedisn't intended to work with multiple compilations simultaneously. Therefore, in order to run it in parallel, we need to make its internal componentsThreadLocal.Tests execution time
Closes: #2014
PR-Codex overview
This PR makes several changes to the codebase, including introducing ThreadLocal variables to improve concurrency and fixing a bug in the
Verticesclass.Detailed summary
Heaps,PhPackage, andVerticesclasses to improve concurrency.Verticesclass where theprimitivemethod was not being called correctly.EOheapclass to use the newHeapsimplementation.PhPackageclass to use the newThreadLocalimplementation.