Feature 2868/pull slack kudos in #2876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, persist automated kudos.
…tent for json when sending it to the poster.
…if the server is not running.
mkimberlin
reviewed
Feb 14, 2025
| @Inject | ||
| private SlackKudosCreator slackKudosCreator; | ||
|
|
||
| @Scheduled(fixedDelay = "10m") |
Member
There was a problem hiding this comment.
I don't think we can count on this because sometimes we scale down completely...and we will end up with multiple channel readers when the app is busy as well. We can end up with up to 10 instances running currently, I think.
Collaborator
Author
There was a problem hiding this comment.
@mkimberlin I just checked in a change to remove the scheduled task and tie it to the CheckServicesController.
…s a kudos from public to private or deletes a public kudos.
This was
linked to
issues
Feb 18, 2025
mkimberlin
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a scheduled task to read slack messages from a configured channel and import user messages as Check-Ins Kudos upon verification with the poster of the slack message.
slackservice directory.CurrentUserServicesImpl.hasPermissionto return false if there is no current user.PulseResponseControllerSLACK_KUDOS_CHANNEL_IDvalue.C0814P2PEV7This will need to be deployed to finish testing.
Also, once this is deployed to production, we will need to add the following scopes to the Check-Ins Integration.
channels:historychat:writegroups:historyim:write