Feature 1374/fix url validations on feedback request flow #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieperm
requested review from
JEdwardBrown,
smithj11,
Approve212,
bhatiam12,
HootDunk,
jahanner,
Maroju100,
mkimberlin,
moshirim and
sagetheherb
|
Side note, I changed two |
JEdwardBrown
approved these changes
Aug 9, 2021
HootDunk
approved these changes
Aug 9, 2021
moshirim
approved these changes
Aug 9, 2021
pieperm
deleted the
feature-1374/fix-url-validations-on-feedback-request-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this, go to:
You should get an error toast regarding the URL.
If you go to:
then that URL should work. Stepping through the request process should not produce any errors. If you change anything in the URL to be invalid (e.g. cut off part of an ID) then you should get an error toast (it will either redirect you or remove that specific query, depending on which ID you altered)
Additionally, for any of the URLs that are generated when stepping through (meaning you didn't manually alter the URL), you should be able to reload the page and return to the same screen with no redirect, errors, or toasts.