Detect if Text.propTypes actually exists for web#11
Merged
obipawan merged 1 commit intoobipawan:masterfrom Apr 14, 2017
Merged
Conversation
I'm using [react-native-web](https://github.com/necolas/react-native-web) in conjunction with this library in order to support more platforms with the same codebase. When building our app for development, everything works properly and this library does exactly what we need it to. However, react-native-web excludes propTypes when you do a production build in order to reduce bundle size and improve performance. This leads to [issues](necolas/react-native-web#423) when libraries depend on propTypes being defined. I propose feature-detecting whether Text.propTypes is actually defined so that people using react-native-web, or any bundlers for native that reduce size agressively, without affecting current users.
Owner
|
Thanks for the addition @RangerMauve |
Owner
|
available on react-native-hyperlink@0.0.9 |
Contributor
Author
|
Yeah, right now we're talking to the authors of the plugin about doing just that here |
This was referenced Jun 4, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using react-native-web in conjunction with this library in order to support more platforms with the same codebase.
When building our app for development, everything works properly and this library does exactly what we need it to.
However, react-native-web excludes propTypes when you do a production build in order to reduce bundle size and improve performance.
This leads to issues when libraries depend on propTypes being defined.
I propose feature-detecting whether Text.propTypes is actually defined so that people using react-native-web, or any bundlers for native that reduce size agressively, without affecting current users.