Feature/identity providers #3865
Conversation
| <template v-slot:default> | ||
| <span | ||
| class="text-secondary" | ||
| v-html="$t('identity_provider.use_nonce', { url: useNonceDefinition })" |
There was a problem hiding this comment.
Url link does not work, check box captures the event. You do not need this fancy link (or put it in a <div class="text-hint"> below the q-checkbox
| v-model="groupsMapping" | ||
| :options="groupsMappingOptions" | ||
| dense | ||
| :label="$t('laguages')" |
There was a problem hiding this comment.
Wrong label, "Groups Mapping" expected
| groupsClaim: 0, | ||
| groupsScript: 1, | ||
| }; | ||
| const groupsMappingOptions = ref([ |
There was a problem hiding this comment.
Don't need to be a ref, it will not change
| { label: t('identity_provider.groups_claim'), value: 'groupsClaim' }, | ||
| { label: t('identity_provider.groups_javascript'), value: 'groupsScript' }, | ||
| ]); | ||
| const groupsMapping = ref(groupsMappingOptions.value[groupsMappingOptionsIndices.groupsClaim]); |
There was a problem hiding this comment.
Hum better to not set this incorrect value at this point
| if (value) { | ||
| if (props.provider) { | ||
| newProvider.value = { ...props.provider }; | ||
| groupsMapping.value = newProvider.value.groupsClaim |
There was a problem hiding this comment.
When groupsClaim is "", the wrong groups mapping strategy is selected, you must check for undefined value instead
| lazy-rules | ||
| > | ||
| </q-input> | ||
| <q-select |
There was a problem hiding this comment.
use emit-value and map-options attributes of q-select
| newProvider.value = { ...props.provider }; | ||
| groupsMapping.value = newProvider.value.groupsClaim | ||
| ? groupsMappingOptions.value[groupsMappingOptionsIndices.groupsClaim] | ||
| : groupsMappingOptions.value[groupsMappingOptionsIndices.groupsScript]; |
There was a problem hiding this comment.
Not correct, groupsMappingOptions is not an object
There was a problem hiding this comment.
Just use 'groupsClaim' or 'groupsScript' (keep it simple and readable)
| const editMode = computed(() => !!props.provider && !!props.provider.name); | ||
| const submitCaption = computed(() => (editMode.value ? t('update') : t('add'))); | ||
| const dialogTitle = computed(() => (editMode.value ? t('identity_provider_edit') : t('identity_provider_add'))); | ||
| const isGroupsMappingByClaim = computed(() => groupsMapping.value.value === 'groupsClaim'); |
There was a problem hiding this comment.
If you use emit-value and map-options on q-select, it will simplify to groupsMapping.value === 'groupsClaim'
| readTimeout: 0, | ||
| } as IDProviderDto; | ||
|
|
||
| const groupsMappingOptionsIndices = { |
There was a problem hiding this comment.
You do not need this since this info is already in the options.
Closes: #3832