Using placeholder rustdoc generation for current crate #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should fix #167, but I don't have an Apple I could use to check it. @obi1kenobi can you test whether this PR fixes the issue? |
obi1kenobi
reviewed
Feb 5, 2023
I don't have an Apple device either. Maybe we can ask the original reporter of #167 to try it once we release this. |
…-generation-for-current
obi1kenobi
approved these changes
Feb 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on #350.
It changes the logic of the tool. Instead of generating the rustdoc of the current crate directly, it uses the baseline's way of creating a placeholder project and running rustdoc on it.