Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and don't report non-breaking renaming re-exports. #330

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Detect and don't report non-breaking renaming re-exports. #330

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
955c67e
Detect and don't report non-breaking renaming re-exports.
obi1kenobi Jan 28, 2023
c540de3
Add crates experiencing false-positives to regression suite.
obi1kenobi Jan 28, 2023
4634ebb
Merge branch 'main' into imports_revamp
obi1kenobi Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add crates experiencing false-positives to regression suite.
  • Loading branch information
@obi1kenobi
obi1kenobi committed Jan 28, 2023
commit c540de3e1633fbe355fcce662ca0e7003253bec2
46 changes: 46 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
- lint
- rust-tests
- run-on-rust-libp2p
- run-on-libp2p-dcutr-relay
- run-on-core-graphics
- run-on-bevy-core
- run-on-bevy-gltf
Expand Down Expand Up @@ -140,6 +141,51 @@ jobs:
- name: Run semver-checks (alternative command)
run: cargo run semver-checks check-release --manifest-path="subject/core/Cargo.toml" --package="libp2p-core"

run-on-libp2p-dcutr-relay:
# Run cargo-semver-checks on a crate with no semver violations,
# to make sure there are no false-positives.
#
# cargo-semver-checks previously reported false-positives here
# due to renaming re-exports causing confusion about which types match each other:
# https://github.com/obi1kenobi/cargo-semver-checks/issues/202
# https://github.com/libp2p/rust-libp2p/pull/2647#issuecomment-1340254920
name: Run cargo-semver-checks on libp2p-dcutr 1.62.0 and libp2p-relay 0.14.0
runs-on: ubuntu-latest
steps:
- name: Checkout cargo-semver-checks
uses: actions/checkout@v3
with:
persist-credentials: false

- name: Checkout rust-libp2p
uses: actions/checkout@v3
with:
persist-credentials: false
repository: 'libp2p/rust-libp2p'
ref: 'be0b62a78fe9d72811b9eda742137cc8ddc4da35'
path: 'subject'

- name: Install rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true

# rust-libp2p requires protobuf-compiler.
- name: Install protobuf-compiler
run: sudo apt install protobuf-compiler

- uses: Swatinem/rust-cache@v2
with:
key: libp2p-dcutr-relay

- name: Run semver-checks on libp2p-dcutr
run: cargo run semver-checks check-release --manifest-path="subject/protocols/dcutr/Cargo.toml"

- name: Run semver-checks on libp2p-relay
run: cargo run semver-checks check-release --manifest-path="subject/protocols/relay/Cargo.toml"

run-on-core-graphics:
# Run cargo-semver-checks on a crate with no semver violations,
# to make sure there are no false-positives.
Expand Down