Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly support is best-effort. Its CI steps are advisory, not required. #83

Merged
merged 2 commits into from
Jul 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/test-action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,20 @@ jobs:
name: Run tests
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
toolchain: ['1.74', 'stable', 'beta', 'nightly']
os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
toolchain: ['1.74', 'stable', 'beta']
experimental: [false]
include:
- os: 'ubuntu-latest'
toolchain: 'nightly'
experimental: true
- os: 'windows-latest'
toolchain: 'nightly'
experimental: true
- os: 'macos-latest'
toolchain: 'nightly'
experimental: true
continue-on-error: ${{ matrix.experimental }}
runs-on: ${{ matrix.os }}
steps:
- name: Checkout the test repository and test with patch change and patch version bump
Expand Down
42 changes: 21 additions & 21 deletions .github/workflows/test-inputs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
with:
package: rio_api, rio_turtle
feature-group: only-explicit-features
feature: generalized
features: generalized

test-exclude:
name: Test input exclude
Expand Down Expand Up @@ -271,14 +271,14 @@ jobs:
uses: actions/checkout@v4
with:
path: action
- name: Install latest beta
uses: dtolnay/rust-toolchain@beta
- name: Set local override to beta
run: rustup override set beta
- name: Run the action with rust-toolchain set to nightly
- name: Install latest stable
uses: dtolnay/rust-toolchain@stable
- name: Set local override to stable
run: rustup override set stable
- name: Run the action with rust-toolchain set to beta
uses: ./action/
with:
rust-toolchain: nightly
rust-toolchain: beta
- name: Get cache key
uses: actions/cache/restore@v4
id: get-cache-key
Expand All @@ -290,14 +290,14 @@ jobs:
restore-keys: |
semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'beta') }}
run: |
echo "The toolchain used by the action should be nightly, but it is not!"
echo "The toolchain used by the action should be beta, but it is not!"
exit 1
- name: Check the active toolchain
run: |
if ! rustup show active-toolchain | grep -q "beta"; then
echo "The active toolchain should be still beta, but it is $(rustup show active-toolchain)!"
if ! rustup show active-toolchain | grep -q "stable"; then
echo "The active toolchain should be still stable, but it is $(rustup show active-toolchain)!"
exit 1
fi

Expand All @@ -314,14 +314,14 @@ jobs:
uses: actions/checkout@v4
with:
path: action
- name: Install latest beta
uses: dtolnay/rust-toolchain@beta
- name: Set override to beta in rust-toolchain.toml file
run: echo -e "[toolchain]\nchannel = \"beta\"" > rust-toolchain.toml
- name: Run the action with rust-toolchain set to nightly
- name: Install latest stable
uses: dtolnay/rust-toolchain@stable
- name: Set override to stable in rust-toolchain.toml file
run: echo -e "[toolchain]\nchannel = \"stable\"" > rust-toolchain.toml
- name: Run the action with rust-toolchain set to beta
uses: ./action/
with:
rust-toolchain: nightly
rust-toolchain: beta
- name: Get cache key
uses: actions/cache/restore@v4
id: get-cache-key
Expand All @@ -333,14 +333,14 @@ jobs:
restore-keys: |
semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'beta') }}
run: |
echo "The toolchain used by the action should be nightly, but it is not!"
echo "The toolchain used by the action should be beta, but it is not!"
exit 1
- name: Check the active toolchain
run: |
if ! rustup show active-toolchain | grep -q "beta"; then
echo "The active toolchain should be still beta, but it is $(rustup show active-toolchain)!"
if ! rustup show active-toolchain | grep -q "stable"; then
echo "The active toolchain should be still stable, but it is $(rustup show active-toolchain)!"
exit 1
fi

Expand Down
Loading