Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cache keys in test-inputs.yml #79

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update cache keys in test-inputs.yml #79

merged 1 commit into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. Update cache keys in test-inputs.yml 

    It's always caching. Or DNS. This time it was caching.

A while back, we changed the default cache key prefix from empty-string to `semver` so that our cache key names don't start with a dash, since users found that confusing.

We should have updated these tests accordingly at the time, but we did not. So how did the PR with the change pass?

It used the caches from older runs of the same job which used the old names. When those caches expired and were GC'd by GitHub, the jobs started failing.

This is what broke CI for #77. This PR will fix it.
    @obi1kenobi
    obi1kenobi authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7d5137f View commit details
    Browse the repository at this point in the history