Merge pull request #18 from obazoud/isr

check-topic.rb: check isr
obazoud · Feb 16, 2017 · 5252384 · 5252384
2 parents 60109eb + 58e6d4a
commit 5252384
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -6,7 +6,7 @@ LineLength:
     Max: 225
 
 AbcSize:
-  Max: 125
+  Max: 140
 
 FileName:
     Enabled: false

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,11 @@ This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachang
 ### Fixed
 ### Changed
 
+## [Unreleased]
+
+### Added
+- check-topic.rb: check isr
+
 ## [0.9.1] - 2017-02-16
 
 ### Fixed

diff --git a/bin/check-topic.rb b/bin/check-topic.rb
@@ -106,8 +106,10 @@ def run
         partitions.each do |num, replica|
           state_json = z.get(path: "/brokers/topics/#{config[:name]}/partitions/#{num}/state")[:data]
           state = JSON.parse(state_json)
-          critical "Topic '#{config[:name]}', unknown leader #{state['leader']}" unless brokers.include? state['leader']
-          critical "Topic '#{config[:name]}', partition #{num} preferred replica is not #{replica[0]}" unless replica[0] == state['leader']
+          critical "Topic '#{config[:name]}', partition #{num}: unknown leader #{state['leader']}" unless brokers.include? state['leader']
+          critical "Topic '#{config[:name]}', partition #{num}: preferred replica is not #{replica[0]}" unless replica[0] == state['leader']
+          critical "Topic '#{config[:name]}', partition #{num}: isr is not consistent" unless (replica - state['isr']).empty? && (state['isr'] - replica).empty?
+          critical "Topic '#{config[:name]}', partition #{num}: unknown isr #{state['isr'] - brokers}" unless (state['isr'] - brokers).empty?
         end
       end