Skip to content

feat: switch to dandydeveloper/redis-ha chart 🚀 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2025

Conversation

tuunit
Copy link
Member

@tuunit tuunit commented Aug 13, 2025

This pull request updates the Helm chart for oauth2-proxy to replace the Bitnami Redis subchart with the dandydeveloper/redis-ha chart, updates the chart version, and adjusts related configuration and test files accordingly. The changes ensure compatibility with the new Redis chart and improve clarity in configuration.

Redis chart migration and configuration:

  • Replaced the Bitnami Redis subchart with the dandydeveloper/redis-ha chart in Chart.yaml dependencies and updated the repository references in .github/workflows/release.yaml and ct.yaml.
  • Updated Redis-related configuration in values.yaml and CI test values files to align with redis-ha parameters, including new recommended settings and documentation links.
  • Modified helper templates and deployment logic to support redis-ha, including updates to fullname generation and Redis URL construction.

Chart version and metadata updates:

  • Bumped the chart version to 8.0.0 in Chart.yaml and updated the changelog annotation to reflect the Redis chart migration.

Alternative to #330

and another solution for #323

@tuunit tuunit force-pushed the feat/switch-to-dandydeveloper-redis-ha branch 3 times, most recently from 05fcb04 to 1896d9d Compare August 13, 2025 06:39
@tuunit tuunit changed the title feat: switch to dandydeveloper/redis-ha chart feat: switch to dandydeveloper/redis-ha chart 🚀 Aug 13, 2025
@tuunit tuunit requested a review from Copilot August 13, 2025 06:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches from the Bitnami Redis chart to the dandydeveloper/redis-ha chart for Redis deployment in oauth2-proxy. This change provides a more suitable Redis High Availability solution while maintaining backwards compatibility for existing configurations.

  • Replace Bitnami Redis chart dependency with dandydeveloper/redis-ha chart
  • Update configuration structure to match new chart's parameters
  • Fix template logic for Redis authentication and connection handling

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
helm/oauth2-proxy/Chart.yaml Updates chart version and replaces Redis dependency with redis-ha chart
helm/oauth2-proxy/values.yaml Updates Redis configuration comments and formatting to match new chart structure
helm/oauth2-proxy/templates/deployment.yaml Fixes Redis authentication check logic
helm/oauth2-proxy/templates/_helpers.tpl Updates Redis connection templates for new chart naming conventions
helm/oauth2-proxy/ci/*.yaml Updates CI test configurations to use new Redis chart parameters
ct.yaml Changes chart repository from Bitnami to dandydeveloper
.github/workflows/release.yaml Updates Helm repository configuration for releases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@tuunit tuunit force-pushed the feat/switch-to-dandydeveloper-redis-ha branch from 1896d9d to 1e9c2dd Compare August 13, 2025 06:47
tuunit added 2 commits August 16, 2025 12:23
Signed-off-by: Jan Larwig <jan@larwig.com>
Signed-off-by: Jan Larwig <jan@larwig.com>
@tuunit tuunit force-pushed the feat/switch-to-dandydeveloper-redis-ha branch from 55e4227 to 1d5bef1 Compare August 17, 2025 09:59
Signed-off-by: Jan Larwig <jan@larwig.com>
@tuunit tuunit merged commit 9b08b04 into main Aug 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants