Skip to content

Hardcoded old em-http-request dependency #173

Closed
@voxik

Description

@voxik

spec.add_development_dependency("em-http-request", "0.2.11")

This version of em-http-request was released 10 years ago. No wonder that running the test suite against more recent version fails:

  1) Error:
EmHttpRequestProxyTest#test_request_proxy_works_with_post_body_params_with_correct_content_type:
ArgumentError: wrong number of arguments (given 1, expected 2)
    /usr/share/gems/gems/em-http-request-1.1.7/lib/em-http/client.rb:27:in `initialize'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:99:in `new'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:99:in `create_client'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:108:in `create_request_proxy'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:24:in `test_request_proxy_works_with_post_body_params_with_correct_content_type'

BTW I am not really em-http-request user. I have just randomly tried to enable this part of test suite for OAuth package on Fedora.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions