Refactoring of max word validation #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wazelin
approved these changes
Oct 19, 2023
poyuki
changed the title
kilatib
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR-4540
Summary
This PR aim to refactor max words validation.
Development impact
With this changes in case if we found in provided with interaction pattern corresponding to Authoring pattern
we ignore pattern matching extract min and max restrictions split string by pattern
/[\s.,:;?!&#%\/*+=]+/and count entries.In case if pattern not corresponding to Authoring pattern system works as before and rely on provided pattern
How to test
!word anotherWord word.with.dots!should be counted more accurate as 5 entries