Feature TR-4391 ensure PHP 8.1 support by the legacy release #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## legacy #321 +/- ##
=========================================
Coverage 87.66% 87.66%
- Complexity 8860 8876 +16
=========================================
Files 829 829
Lines 22021 22051 +30
=========================================
+ Hits 19304 19331 +27
- Misses 2717 2720 +3
Continue to review full report at Codecov.
|
wazelin
changed the title
gabrielfs7
reviewed
Jul 18, 2022
| sprintf('Undefined property: %s::%s', SerializableDomDocument::class, $property) | ||
| ); | ||
|
|
||
| $dom->$property; |
There was a problem hiding this comment.
I am getting this error locally:
Time: 01:53.357, Memory: 84.00 MB
There was 1 error:
1) qtismtest\common\dom\SerializableDomDocumentTest::testAccessingInexistentProperty
Undefined property: qtism\common\dom\SerializableDomDocument::test
/Users/gabriel.soares/repos/qti-sdk/qtism/common/dom/SerializableDomDocument.php:164
/Users/gabriel.soares/repos/qti-sdk/test/qtismtest/common/dom/SerializableDomDocumentTest.php:42
phpvfscomposer:///Users/gabriel.soares/repos/qti-sdk/vendor/phpunit/phpunit/phpunit:97
There was a problem hiding this comment.
Yes, problem with 7.1 and 7.2 with correctly catch this exception I research a solution to downgrade the $this->expectWarning(); method
There was a problem hiding this comment.
Test is passing now, thanks
wazelin
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR-4391
Development impact
SerializableDomDocumentno longer extendsDOMDocumentdue to a serialization-preventing bug in PHP 8.1 DOMNode serialization on PHP ^8.1 php/php-src#8996ExternalQtiComponentasSerializableDomDocumentnot likeDOMDocument