Display number of shares in Sapphire undelegate transactions #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaja-osojnik
requested review from
lukaw3d,
buberdds,
csillag and
lubej
as code owners
Deployed to Cloudflare Pages
|
lukaw3d
reviewed
Apr 11, 2025
kaja-osojnik
force-pushed
the
kaja/sapphire-undelegate-shares
branch
from
b84f6ab to
65dd244
Compare
kaja-osojnik
added a commit
that referenced
this pull request
Apr 22, 2025
lukaw3d
changed the title
lukaw3d
changed the title
lukaw3d
force-pushed
the
kaja/sapphire-undelegate-shares
branch
from
ff8dfea to
a5cd9d2
Compare
lukaw3d
approved these changes
Apr 23, 2025
Comment on lines
+161
to
+169
| transaction.amount && transaction.amount !== '0' ? ( | ||
| <RoundedBalance value={transaction.amount} ticker={transaction.amount_symbol} /> | ||
| ) : ( | ||
| <RoundedBalance | ||
| compactLargeNumbers | ||
| value={transaction?.body?.shares} | ||
| ticker={t('common.shares')} | ||
| /> | ||
| ), |
There was a problem hiding this comment.
I changed this to better match ConsensusAmount
before:
<RoundedBalance
compactLargeNumbers
value={transaction?.body?.shares ?? transaction.amount}
ticker={transaction?.body?.shares ? t('common.shares') : transaction.amount_symbol}
/>
lukaw3d
force-pushed
the
kaja/sapphire-undelegate-shares
branch
2 times, most recently
from
cd6d46a to
e55ea08
Compare
lukaw3d
force-pushed
the
kaja/sapphire-undelegate-shares
branch
from
e55ea08 to
17a2204
Compare
lukaw3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show undelegated shares on Sapphire instead of Amount field value.
Fixes: #1599
https://explorer.dev.oasis.io/testnet/sapphire/tx/6f1b5e74c32422f3295a54b0a56812d49aefe9901db9a75c19c039228164170d
https://explorer.dev.oasis.io/testnet/sapphire/block/8594080
Before:
After:
