Improve detecting if API is out-of-date #1876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/out-of-date-more
branch
from
79e6c95 to
c105c17
Compare
buberdds
approved these changes
Apr 25, 2025
| @@ -24,6 +24,7 @@ export const useIsApiReachable = ( | |||
| export type FreshnessInfo = { | |||
| unavailable?: boolean | |||
| outOfDate?: boolean | |||
There was a problem hiding this comment.
It looks like redundancy in having two vars for handling one state. Doesn't outOfDate duplicate outOfDateReason? Would be simpler to have single source of truth for this state checking.
There was a problem hiding this comment.
Yes
That can be a separate refactoring, I think it would require some hundred lines of changes in existing code and I'd rather avoid conflicts
lukaw3d
force-pushed
the
lw/out-of-date-more
branch
from
c105c17 to
1ad526a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882