Issue 211 - Fix

[jordanVoss]

In this PR I updated the two warning messages in the v21 shoulds.py file as outlined in Issue 211. I also tested it by running the validator against the file provided in that issue and confirming that the new messages were shown.

The full output of running the validator against the file is as follows:

    [!] Warning: bundle--fdd39a2e-b67c-11e3-bcc9-f01faf20d111: {103} Given ID value bundle--fdd39a2e-b67c-11e3-bcc9-f01faf20d111 is not a valid UUIDv4 ID.
    [!] Warning: malware--fdd60b30-b67c-11e3-b0b9-f01faf20d111: {103} Given ID value malware--fdd60b30-b67c-11e3-b0b9-f01faf20d111 is not a valid UUIDv4 ID.
    [!] Warning: malware--fdd60b30-b67c-11e3-b0b9-f01faf20d111: {216} The value contained in malware_types is permitted, but is not in the malware-type-ov vocabulary. vocabulary.
    [!] Warning: indicator--a932fcc6-e032-476c-a26f-cb970a5a1ade: {214} The value contained in indicator_types is permitted, but is not in the indicator-type-ov vocabulary. vocabulary.
    [!] Warning: indicator--a932fcc6-e032-476c-a26f-cb970a5a1ade: {303} Both the name and description properties SHOULD be present.
    [!] Warning: relationship--2f9a9aa9-108a-4333-83e2-4fb25add0463: {202} 'indicate' is not a suggested relationship type for 'indicator' objects.

[CLAassistant]

All committers have signed the CLA.

[rpiazza]

Look at the run for 3.11, which runs the linter. There is a failure.

Also, the warning message for relationships doesn't seem to be working, based on the output above.

"Warning: relationship--2f9a9aa9-108a-4333-83e2-4fb25add0463: {202} 'indicate' is not a suggested relationship type for 'indicator' objects."

[rpiazza]

Please look at the errors in the test run.

Additionally, You have changed the error messages in relationships_strict so they don't capture what is happening. There are three different errors, but basically, you just need to change the beginning of each error message to be:

'%s' is permitted, but not a suggested...."

But otherwise no other changes.

It might make sense to start from the original should.py file, and that will fix the errors in the test also.

[rpiazza]

Minor pre-commit lint error:

stix2validator/v21/shoulds.py:1710:26: W292 no newline at end of file