Skip to content

Make it easier to use testutil with other test frameworks by accepting an interface, not a testing.T #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Make it easier to use testutil with other test frameworks by accepting an interface, not a testing.T #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions request_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package testutil
//
// var body RequestBody
// var response ResponseBody
// t is *testing.T, from a unit test
// t is TestReporter, use *testing.T from a unit test
// e is *echo.Echo
// response := NewRequest().Post("/path").WithJsonBody(body).GoWithHTTPHandler(t, e)
// err := response.UnmarshalBodyToObject(&response)
Expand All @@ -31,9 +31,12 @@ import (
"net/http"
"net/http/httptest"
"strings"
"testing"
)

type TestReporter interface {
Errorf(format string, args ...any)
}

func NewRequest() *RequestBuilder {
return &RequestBuilder{
Headers: make(map[string]string),
Expand Down Expand Up @@ -138,7 +141,7 @@ func (r *RequestBuilder) WithCookieNameValue(name, value string) *RequestBuilder

// GoWithHTTPHandler performs the request, it takes a pointer to a testing context
// to print messages, and a http handler for request handling.
func (r *RequestBuilder) GoWithHTTPHandler(t *testing.T, handler http.Handler) *CompletedRequest {
func (r *RequestBuilder) GoWithHTTPHandler(t TestReporter, handler http.Handler) *CompletedRequest {
if r.Error != nil {
// Fail the test if we had an error
t.Errorf("error constructing request: %s", r.Error)
Expand Down