Merged
Conversation
We have some old code which started to fail lint due to the linter being pedantic. Fix lint issues.
jamietanna
approved these changes
Oct 30, 2025
Member
jamietanna
left a comment
jamietanna
left a comment
There was a problem hiding this comment.
Were these changes not picked up on by CI?
Member
Author
|
They were not. The code around calling functions on embedded struct hasn't changed in ages. |
Member
|
It looks like it's because we'd not approved the CI from the first-time contribution in #72 so no CI checks ran - if they had, we'd have had a failing PR build before it landed on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some old code which started to fail lint due to the linter being pedantic. Fix lint issues.