[GLUTEN-2038][VL] Improve parquet write using arrow chunked array #326
+80
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
ulysses-you
commented
Jun 26, 2023
| std::unique_ptr<dwio::common::DataSink> sink, | ||
| memory::MemoryPool& pool, | ||
| int32_t rowsInRowGroup, | ||
| int64_t maxRowGroupBytes, |
Author
There was a problem hiding this comment.
seems rowsInRowGroup is dead code
JkSelf
approved these changes
Jun 26, 2023
Collaborator
JkSelf
left a comment
JkSelf
left a comment
There was a problem hiding this comment.
LGTM. And can you help to upstream this optimization into upstream?
| std::unique_ptr<dwio::common::DataSink> sink, | ||
| memory::MemoryPool& pool, | ||
| int32_t rowsInRowGroup, | ||
| int64_t maxRowGroupBytes, |
Author
|
@JkSelf sure |
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 26, 2023
…ct#326) Co-authored-by: youxiduo <youxiduo@corp.netease.com>
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 27, 2023
…ct#326) Co-authored-by: youxiduo <youxiduo@corp.netease.com>
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 30, 2023
…ct#326) Co-authored-by: youxiduo <youxiduo@corp.netease.com>
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 3, 2023
…ct#326) Co-authored-by: youxiduo <youxiduo@corp.netease.com>
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 4, 2023
…ct#326) Co-authored-by: youxiduo <youxiduo@corp.netease.com>
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 17, 2023
…ct#326) Co-authored-by: youxiduo <youxiduo@corp.netease.com>
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see apache/incubator-gluten#2039