fix metrics for sort and window operation #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
cc @zhouyuan , thanks. |
zhouyuan
approved these changes
Jun 13, 2023
marin-ma
approved these changes
Jun 13, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 14, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 14, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 14, 2023
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Jun 20, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 20, 2023
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Jun 20, 2023
xieqi
pushed a commit
that referenced
this pull request
Jun 21, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 25, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 25, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 26, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 27, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 3, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 4, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 11, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 17, 2023
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Velox calculated wrong total time metrics for sort and window operations.
nextOp->noMoreInput()'s duration is recorded in paraent op's stats, but for sort and window operations, almost all works are executed innoMoreInputfunction. So we observed wrong total time metrics for them.Before:
After:
