Skip to content

Fix casting from string to decimal #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2023
Merged

Fix casting from string to decimal #281

merged 2 commits into from
May 26, 2023

Conversation

@rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented May 25, 2023

  • Fix the wrong result when the length of decimal places is larger than the required scale.
  • Support converting a string number of scientific notation to decimal.
  • Support rounding a decimal according to the required scale.

With above fixes, cases like below can have correct result.

test case previous result correct result in Spark
cast("0.00000000000000000000000000000000000000000001" as DecimalType(38, 0)) null 0
cast("6E+37" as DecimalType(38, 0)) null 60000000000000000000000000000000000000
cast("9.95" as DecimalType(3, 1)) 9.9 10.0

@rui-mo rui-mo mentioned this pull request May 25, 2023
Merged
@rui-mo rui-mo requested a review from PHILO-HE May 26, 2023 05:08
@rui-mo rui-mo merged commit 40fcf8f into oap-project:main May 26, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request May 30, 2023
@rui-mo @zhejiangxiaomai
Fix casting from string to decimal (oap-project#281)
563ecff
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request May 31, 2023
@rui-mo @zhejiangxiaomai
Fix casting from string to decimal (oap-project#281)
757060d
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request May 31, 2023
@zhejiangxiaomai
Folder: type, vector
8472a9c 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request May 31, 2023
@zhejiangxiaomai
Folder: type, vector
c20fa1d 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request May 31, 2023
@zhejiangxiaomai
Folder: type, vector
00c85ae 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 25, 2023
@rui-mo @zhejiangxiaomai
Fix casting from string to decimal (oap-project#281)
048a378
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 25, 2023
@rui-mo @zhejiangxiaomai
Fix casting from string to decimal (oap-project#281)
e6b2073
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 26, 2023
@rui-mo @zhejiangxiaomai
Fix casting from string to decimal (oap-project#281)
86c12a2
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 27, 2023
@rui-mo @zhejiangxiaomai
Fix casting from string to decimal (oap-project#281)
a4d29b8
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request Jul 3, 2023
@zhejiangxiaomai
Folder: type, vector
d9654f1 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request Jul 4, 2023
@zhejiangxiaomai
Folder: type, vector
e672fb1 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request Jul 11, 2023
@zhejiangxiaomai
Folder: type, vector
35bd249 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request Jul 12, 2023
@zhejiangxiaomai
Folder: type, vector
a5e138f 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request Jul 12, 2023
@zhejiangxiaomai
Folder: type, vector
f15bf95 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
zhejiangxiaomai added a commit to zhejiangxiaomai/velox that referenced this pull request Jul 17, 2023
@zhejiangxiaomai
Folder: type, vector
22ac6ac 
relative pr:

Support more data types for read filter oap-project#139
Fix cast double to decimal oap-project#179
Fix casting from string to decimal oap-project#281
Support cast decimal to int oap-project#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal oap-project#169
Disable tokenizing the path by dot oap-project#109
Serialize and deserialize RowVector oap-project#250
Support datetime pattern in spark oap-project#94
marin-ma pushed a commit to marin-ma/velox-oap that referenced this pull request Dec 15, 2023
@rui-mo
fix whole stage suite (oap-project#281)
017cc85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PHILO-HE PHILO-HE PHILO-HE approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rui-mo @PHILO-HE