-
Notifications
You must be signed in to change notification settings - Fork 64
add spark comparison functions #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you add some tests to get infinity involved in the comparison? E.g., compare infinity with Nan. I remember this case is also specially handled. |
|
Vector function has a null behavior by default, which produces null result if any input is null. So I think we can skip the check for null. See Thanks! |
updated. |
PHILO-HE
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add comparison vector functions for equalto, lessthan, greaterthan, lessthanorequal and greaterthanorequal. NaN value is specially handled.