Skip to content

Conversation

@yma11
Copy link
Collaborator

@yma11 yma11 commented May 24, 2023

add comparison vector functions for equalto, lessthan, greaterthan, lessthanorequal and greaterthanorequal. NaN value is specially handled.

@PHILO-HE
Copy link
Collaborator

Can you add some tests to get infinity involved in the comparison? E.g., compare infinity with Nan. I remember this case is also specially handled.

@yma11
Copy link
Collaborator Author

yma11 commented Jun 1, 2023

@PHILO-HE Seems no need update functions internal. Add some tests for Infinity, referring spark doc.

@PHILO-HE
Copy link
Collaborator

PHILO-HE commented Jun 1, 2023

Vector function has a null behavior by default, which produces null result if any input is null. So I think we can skip the check for null. See VectorFunction.h:

  virtual bool isDefaultNullBehavior() const {
    return true;
  }

Thanks!

@yma11
Copy link
Collaborator Author

yma11 commented Jun 2, 2023

Vector function has a null behavior by default, which produces null result if any input is null. So I think we can skip the check for null. See VectorFunction.h:

  virtual bool isDefaultNullBehavior() const {
    return true;
  }

Thanks!

updated.

Copy link
Collaborator

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PHILO-HE PHILO-HE merged commit f3d5e0f into oap-project:main Jun 2, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 2, 2023
zhejiangxiaomai pushed a commit that referenced this pull request Jun 20, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 25, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 25, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 26, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jun 27, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 3, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 4, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 11, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 12, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 12, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Jul 17, 2023
@yma11 yma11 deleted the compare branch January 24, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants