add decimal column reader support #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
reviewed
May 15, 2023
| const uint32_t SelectiveLongDecimalColumnReader::MAX_PRECISION_128; | ||
|
|
||
| const int64_t | ||
| SelectiveLongDecimalColumnReader::POWERS_OF_TEN[MAX_PRECISION_64 + 1] = { |
Collaborator
There was a problem hiding this comment.
Can we use it in both Long and Short Decimal readers?
rui-mo
reviewed
May 15, 2023
Collaborator
rui-mo
left a comment
rui-mo
left a comment
There was a problem hiding this comment.
Can we open a PR in Gluten to test this branch? This can help ensure the CI works.
| precision_ = dataType->asShortDecimal().precision(); | ||
| scale_ = dataType->asShortDecimal().scale(); | ||
|
|
||
| auto& stripe = params.stripeStreams(); |
Collaborator
|
Offline discussed with @zuochunwei to open one PR to test. |
Collaborator
Author
|
Collaborator
Author
|
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 18, 2023
add decimal column reader support. --------- Co-authored-by: zuochunwei <zuochunwei@meituan.com> Co-authored-by: zhejiangxiaomai <zhenhui.zhao@intel.com>
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
add decimal column reader support. --------- Co-authored-by: zuochunwei <zuochunwei@meituan.com> Co-authored-by: zhejiangxiaomai <zhenhui.zhao@intel.com>
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 25, 2023
add decimal column reader support. --------- Co-authored-by: zuochunwei <zuochunwei@meituan.com> Co-authored-by: zhejiangxiaomai <zhenhui.zhao@intel.com>
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 25, 2023
add decimal column reader support. --------- Co-authored-by: zuochunwei <zuochunwei@meituan.com> Co-authored-by: zhejiangxiaomai <zhenhui.zhao@intel.com>
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 26, 2023
add decimal column reader support. --------- Co-authored-by: zuochunwei <zuochunwei@meituan.com> Co-authored-by: zhejiangxiaomai <zhenhui.zhao@intel.com>
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 27, 2023
add decimal column reader support. --------- Co-authored-by: zuochunwei <zuochunwei@meituan.com> Co-authored-by: zhejiangxiaomai <zhenhui.zhao@intel.com>
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 3, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 4, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 11, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 17, 2023
relative pr: add decimal column reader support oap-project#254 Add utility method MemoryUsageTracker::highUsage() oap-project#227 Support parquet read case sensitive option oap-project#126 Make varchar and varbinary compatible oap-project#115 Create folder if not exits on HDFS write oap-project#267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested the reading of short decimal type column by query_benchmark
replace #244