Add expand op in velox #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JkSelf
reviewed
Apr 14, 2023
JkSelf
reviewed
Apr 14, 2023
Author
JkSelf
reviewed
Apr 18, 2023
JkSelf
approved these changes
Apr 19, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 19, 2023
Add expand op in velox. This op is different from group id, which accepts projection sets and do the projection. This aligns spark ExpandExec's behavior. We don't need to do the columns' mapping in gluten side. --------- Co-authored-by: zhli1142015 <zhli@pczhlich.fareast.corp.microsoft.com>
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 20, 2023
Add expand op in velox. This op is different from group id, which accepts projection sets and do the projection. This aligns spark ExpandExec's behavior. We don't need to do the columns' mapping in gluten side. --------- Co-authored-by: zhli1142015 <zhli@pczhlich.fareast.corp.microsoft.com>
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: Add expand op in velox oap-project#199 Add ValueStreamNode operator oap-project#204 Allow decimal in casting string to int oap-project#215
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 3, 2023
relative pr: Add expand op in velox oap-project#199 Add ValueStreamNode operator oap-project#204 Allow decimal in casting string to int oap-project#215
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Add expand op in velox oap-project#199 Add ValueStreamNode operator oap-project#204 Allow decimal in casting string to int oap-project#215
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 11, 2023
relative pr: Add expand op in velox oap-project#199 Add ValueStreamNode operator oap-project#204 Allow decimal in casting string to int oap-project#215
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: Add expand op in velox oap-project#199 Add ValueStreamNode operator oap-project#204 Allow decimal in casting string to int oap-project#215
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: Add expand op in velox oap-project#199 Add ValueStreamNode operator oap-project#204 Allow decimal in casting string to int oap-project#215
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Add expand op in velox oap-project#199 Add ValueStreamNode operator oap-project#204 Allow decimal in casting string to int oap-project#215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add expand op in velox.
This op is different from group id, which accepts projection sets and do the projection. This aligns spark ExpandExec's behavior. We don't need to do the columns' mapping in gluten side.