-
Notifications
You must be signed in to change notification settings - Fork 64
feat: support reading DeltaByteArray encoding for Decimals #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: update
Are you sure you want to change the base?
Conversation
fix decimal avg function precision issue Alchemy-item: [[6020] Spark sql avg agg function support decimal](oap-project#511 (comment)) commit 1/1 - 475f069
Alchemy-item: [[oap] Register merge extract companion agg functions without suffix](oap-project#512 (comment)) commit 1/1 - c1e41a3
Signed-off-by: Yuan <yuanzhou@apache.org> Alchemy-item: [[11771] [11772] Fix smj result mismatch issue](oap-project#514 (comment)) commit 1/1 - 8c77615
Alchemy-item: [[11067] Support scan filter for decimal in ORC](oap-project#513 (comment)) commit 1/1 - 60fce69
Alchemy-item: [ [5962] Support struct schema evolution matching by name](oap-project#805 (comment)) commit 1/1 - e3d77fd
…rtType Alchemy-item: [[13620] fix: Add config for requested type check in ReaderBase::conve…](oap-project#855 (comment)) commit 1/1 - 924fc2e
62f96b6 to
ec7dc4e
Compare
198f2b4 to
6d118a5
Compare
|
There're some legal restrictions to do it in Russia. It would be great if you merge it in your fork first. So it would be published in repo that has no direct relations with Meta. Then you are able to share it to any other repo on your own. I'm not interested in direct commit into Meta's repo. |
7ea7352 to
151e9ef
Compare
|
@4ertus2 Thanks for extending the support of decimal reader.
Would you mind providing a test with this type of Parquet file? It could be added in the https://github.com/oap-project/velox/blob/update/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp. Thanks. |
|
I cannot share samples I tested on. They have confidential info inside. I also asked for a sample here apache/parquet-testing#89 But there's no-one who want to help with it yet. |
351ef91 to
6e833ba
Compare
|
@4ertus2 Thanks for sharing the context. |
344fde6 to
7a31679
Compare
c5d9aac to
9f0ef60
Compare
704b7d6 to
9f74a76
Compare
07f098d to
537e695
Compare
e963905 to
b228025
Compare
cc6eb06 to
7dfc0d2
Compare
Decimal could be represented as FixedLengthByteArrays or ByteArrays in parquet files. FixedLengthByteArrays and ByteArrays could be encoded with DeltaByteArray encoding.
PR adds support for reading such Decimal columns.