Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection when a bootable partition in on RAID #1260

Merged
merged 1 commit into from
Jul 20, 2024

Commits on Jul 17, 2024

  1. Fix detection when a bootable partition in on RAID

    On my server, leapp preupgrade fail with the following error:
    
    	Traceback (most recent call last):
    	  File "/usr/lib64/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    	    self.run()
    	  File "/usr/lib64/python2.7/multiprocessing/process.py", line 114, in run
    	    self._target(*self._args, **self._kwargs)
    	  File "/usr/lib/python2.7/site-packages/leapp/repository/actor_definition.py", line 74, in _do_run
    	    actor_instance.run(*args, **kwargs)
    	  File "/usr/lib/python2.7/site-packages/leapp/actors/__init__.py", line 289, in run
    	    self.process(*args)
    	  File "/usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/scangrubdevpartitionlayout/actor.py", line 18, in process
    	    scan_layout_lib.scan_grub_device_partition_layout()
    	  File "/usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/scangrubdevpartitionlayout/libraries/scan_layout.py", line 91, in scan_grub_device_partition_layout
    	    dev_info = get_partition_layout(device)
    	  File "/usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/scangrubdevpartitionlayout/libraries/scan_layout.py", line 79, in get_partition_layout
    	    part_start = int(part_info[2]) if len(part_info) == len(part_all_attrs) else int(part_info[1])
    	ValueError: invalid literal for int() with base 10: '*'
    
    This is caused by the following line:
    
    	/dev/sda1   *        2048     1026047      512000   fd  Linux raid autodetect
    
    I have my server on EL7 with / using a Linux RAID so len(part_info) != len(part_all_attrs), hence why
    it try to convert '*' to int.
    mscherer committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    da43a29 View commit details
    Browse the repository at this point in the history