Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for udevadminfo actor #1186

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add test for udevadminfo actor #1186

merged 1 commit into from
Mar 28, 2024

Conversation

tomasfratrik
Copy link
Member

Test if produced message has correctly parsed database exported from command 'udevamd info -e', using mocked database output in files directory.

Jira: OAMG-1277

@github-actions GitHub Actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42
Note that first time contributors cannot run tests automatically - they will be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@tomasfratrik tomasfratrik force-pushed the add_udevadm_test branch 2 times, most recently from bb67bef to 4a82445 Compare February 27, 2024 14:10
@tomasfratrik tomasfratrik force-pushed the add_udevadm_test branch 2 times, most recently from 0a03bbe to c830075 Compare March 4, 2024 10:49
@tomasfratrik tomasfratrik marked this pull request as ready for review March 4, 2024 12:16
@tomasfratrik
Add unit tests for actor udevamdinfo
090f7ee 
* Move actor's process to its library
* Add check for run in process
* Create file with short output of 'udevamd info -e' for testing
  purposes
* Add unit tests for actor

Jira: OAMG-1277
pirat89
pirat89 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@pirat89 pirat89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks. 🎆 first one merged! - just giving it a time to finish tests that are stuck on COPR.

@pirat89
Copy link
Member

pirat89 commented Mar 28, 2024 •
edited
Loading

/packit build

fernflower
fernflower approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@fernflower fernflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fernflower fernflower merged commit b65ef94 into oamg:master Mar 28, 2024
15 checks passed
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalHe MichalHe MichalHe left review comments

@matejmatuska matejmatuska matejmatuska left review comments

@fernflower fernflower fernflower approved these changes

@pirat89 pirat89 pirat89 approved these changes

Assignees
No one assigned
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomasfratrik @pirat89 @fernflower @MichalHe @matejmatuska