Specify import type when applicable#244
Merged
Merged
Conversation
kitsonk
requested changes
Sep 14, 2020
Member
kitsonk
left a comment
kitsonk
left a comment
There was a problem hiding this comment.
Thanks. Please see below. Also, .github/workflows/oak-ci.yml should be updated so that the CI runs with the --unstable flag so that it would break if there was a regression, as well as running without --unstable as we shouldn't have any other dependency on --unstable
This fixes TS1371 that raises in deno 1.4.0 with the --unstable flag Deno typescript check is getting stricter by default: https://deno.land/manual/getting_started/typescript
esquevin
force-pushed
the
fix-import-type
branch
from
3fcd052 to
3a0f997
Compare
esquevin
force-pushed
the
fix-import-type
branch
from
2105f17 to
3fb6dff
Compare
kitsonk
approved these changes
Sep 15, 2020
Member
kitsonk
left a comment
kitsonk
left a comment
There was a problem hiding this comment.
Awesome, thank you very much for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes TS1371 that raises in deno 1.4.0 with the --unstable flag
Addresses #243