Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle improvement #975

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JasperB-TeamBlue
Copy link

Fixes issue # (delete if not relevant)

Changes introduced with this PR

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y]

Altered documents that threw errors for the newly defined checkstyle configuration

Signed-off-by: Jasper Berton <jasper.berton@team.blue>
Changed to latest version 10.20.0 due to support available for:
- WhitespaceAfter for LITERAL_RETURN, LITERAL_TRY, LITERAL_SYNCHRONIZED, LITERAL_CATCH and LITERAL_FINALLY

Signed-off-by: Jasper Berton <jasper.berton@team.blue>
Changed rules and suppressions used by checkstyle to enforce more strict whitespace rules

Signed-off-by: Jasper Berton <jasper.berton@team.blue>
Copy link
Member

@dupondje dupondje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git diff -w master..checkstyle-improvement gives the only work to review, and this is fine :)

CI should now also pass after fixes in the build-dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants